Skip to contentSkip to conversation

x86/dma-mapping: override via_no_dac for new VIA PCI bridges

PATCH David Wang 3 participants 4 messages Apr 17, 2018

lore
Share & tools
lore

David Wang

author
#0 lore raw
Quoted 14 lines

-----邮件原件-----
发件人: Christoph Hellwig [mailto:[email protected]]
发送时间: 2018年4月16日 20:34
收件人: David Wang <[email protected]>
抄送: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected] 主题: Re: [PATCH] x86/dma-mapping: override via_no_dac for new VIA PCI bridges

Quoted 7 lines
Quoted 4 lines · David Wang

PCI bridges integrated in new VIA chipset/SoC have no DAC issue. Enable DAC for the platforms with these chipset/SoC can improve DMA performance about 20% when DRAM size > 4GB.

So we get an exception to an exception? Is there any way to figure out

the

Quoted 1 line

PCI IDs actually affected?

Yes.

Do you mean we should list the PCI IDs of the PCI bridges which have no DAC issue?
There are lots of PCI bridges(PCIE root ports) in our new chipsets/SoCs. And no DMA issues found.
So, we only want to recognize the chipset/SoC by reading VID/DID of Bus 0, Device 17, function 0.

Thx.
---
David

#1 lore raw
Quoted 6 lines · David Wang
Quoted 6 lines · David Wang
Quoted 4 lines

PCI bridges integrated in new VIA chipset/SoC have no DAC issue. Enable DAC for the platforms with these chipset/SoC can improve DMA performance about 20% when DRAM size > 4GB.

Quoted 7 lines
Quoted 1 line

So we get an exception to an exception? Is there any way to figure out

the

Quoted 1 line

PCI IDs actually affected?

Yes.

Do you mean we should list the PCI IDs of the PCI bridges which have no DAC issue?

The question was rather to have a list of PCI IDs for those chipsets which have the problem and set the 'disable' flag only for those. That makes a lot more sense than making a list of new chips which disable the disable flag.

Thanks,

tglx

#2 lore raw
Quoted 3 lines · Thomas Gleixner

The question was rather to have a list of PCI IDs for those chipsets which have the problem and set the 'disable' flag only for those. That makes a lot more sense than making a list of new chips which disable the disable flag.

Agreed.

There are a few other things I'd like to do in this area while we're at it (I'm happy to do the work, not trying to offload it to David or Thomas):

(1) make the nodac flag a per-device flag. Set for every device under one of the affected VIA bridges, or for all PCI devices if the nodac command line option is used
(2) move that flag into the common struct device (or the to be designed dma struct hanging off it in the future) and make that bit handled in common code as there is a common Xilinx host bridge with a 32-bit dma limitation
(3) kill of the forcesac option, which was a strange performance tweak back in plain PCI days, which probably didn't even work as expected to start with.

#3 lore raw
Quoted 11 lines · Christoph Hellwig
Quoted 3 lines · Thomas Gleixner

The question was rather to have a list of PCI IDs for those chipsets which have the problem and set the 'disable' flag only for those. That makes a lot more sense than making a list of new chips which disable the disable flag.

Agreed.

There are a few other things I'd like to do in this area while we're at it (I'm happy to do the work, not trying to offload it to David or Thomas):

Quoted 10 lines

(1) make the nodac flag a per-device flag. Set for every device under one of the affected VIA bridges, or for all PCI devices if the nodac command line option is used
(2) move that flag into the common struct device (or the to be designed dma struct hanging off it in the future) and make that bit handled in common code as there is a common Xilinx host bridge with a 32-bit dma limitation
(3) kill of the forcesac option, which was a strange performance tweak back in plain PCI days, which probably didn't even work as expected to start with.

Sounds good.