Skip to contentSkip to conversation

https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-dbus-interfaces/+/16468/ needs your review

DISCUSSION Yong Li 2 participants 2 messages Jan 9, 2019 – Jan 14, 2019 2 messages not in the archive

lore
Share & tools
lore

Yong Li

author
#2 lore raw
In reply to a message not in the archive

Hi Brad,

Thanks for your mail. For this change, It should be better to add it into 2.6. Based on this change, I will start to add the implementation in the IPMI watchdog command.

Thanks,
Yong
-----Original Message-----
From: Brad Bishop <[email protected]>
Sent: Wednesday, January 9, 2019 11:35 AM
To: Yong Li <[email protected]>
Cc: Tanous, Ed <[email protected]>
Subject: Re: https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-dbus-interfaces/+/16468/ needs your review

Quoted 12 lines · Yong Li

HI Brad,

Sorry to disturbing, but the below code review is idle for serval days:
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-dbus-interface
s/+/16468/

several reviewers had “+1”, could you help to review or merge it please?

Thanks,
Yong

Hi Yong

Please copy the list with this sort of thing. In fact you should just always copy the list. Thanks.

I’m not merging much right now because we are in the middle of trying to release 2.6:
https://lists.ozlabs.org/pipermail/openbmc/2019-January/014503.html

If you think it should be in 2.6, we can probably do that. Do you need it in 2.6?

I expect to start merging code again after the three days are over and we branch.

thx - brad=

#3 lore raw
Quoted 8 lines · Yong Li

Hi Brad,

Thanks for your mail. For this change, It should be better to add it into 2.6. Based on this change, I will start to add the implementation

"add the implementation" sounds like new function. It isn’t appropriate to be adding new function to the release at this point. Please let me know if I am not understanding something.

We are branching for 2.6 today (or possibly tomorrow) at which point your change could be merged into master (and not 2.6). Please let us know if that isn’t sensible.

Quoted 37 lines

in the IPMI watchdog command.

Thanks,
Yong
-----Original Message-----
From: Brad Bishop <[email protected]>
Sent: Wednesday, January 9, 2019 11:35 AM
To: Yong Li <[email protected]>
Cc: Tanous, Ed <[email protected]>
Subject: Re: https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-dbus-interfaces/+/16468/ needs your review

Quoted 12 lines · Yong Li

HI Brad,

Sorry to disturbing, but the below code review is idle for serval days:
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-dbus-interface
s/+/16468/

several reviewers had “+1”, could you help to review or merge it please?

Thanks,
Yong

Hi Yong

Please copy the list with this sort of thing. In fact you should just always copy the list. Thanks.

I’m not merging much right now because we are in the middle of trying to release 2.6:
https://lists.ozlabs.org/pipermail/openbmc/2019-January/014503.html

If you think it should be in 2.6, we can probably do that. Do you need it in 2.6?

I expect to start merging code again after the three days are over and we branch.

thx - brad=