"check_netns_enabled.c" build failed with "2010-02-10" cvs
Hi,
I tried to build with "2010-02-10" cvs in my systems.
I tried in RHEL5.4 (2.6.18-164.el5) and RHEL4.8 (2.6.9-89.ELsmp). But "make" failed in "check_netns_enabled.c" as follows in RHEL4.8:
------------
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -I/home/LTP/ltp-2010-02-10/testcases/kernel/include -I/home/LTP/ltp-2010-02-10/testcases/kernel/containers/netns/../libclone -I../../../../include -I../../../../include -L/home/LTP/ltp-2010-02-10/testcases/kernel/containers/netns/../libclone
-L../../../../lib check_netns_enabled.c -lltp -o check_netns_enabledcheck_netns_enabled.c: In function `main':
check_netns_enabled.c:40: warning: implicit declaration of function `unshare'
/tmp/cciXlXlf.o(.text+0x2c): In function `main':/home/LTP/ltp-2010-02-10/testcases/kernel/containers/netns/check_netns_enabl ed.c:40: undefined reference to `unshare'
collect2: ld returned 1 exit status
make[4]: *** [check_netns_enabled] Error 1
make[4]: Leaving directory `/home/LTP/ltp-2010-02-10/testcases/kernel/containers/netns'
------------
"unshare()" function was supported after kernel 2.6.16. Therefore, "make" of "check_netns_enabled.c" failed in RHEL4.8, I think.
I made patch and "make" succeeded:
============
--- ./testcases/kernel/containers/netns/check_netns_enabled.c 2008-09-19
21:17:10.000000000 +0900
+++ ./testcases/kernel/containers/netns/check_netns_enabled.c.new
2010-02-10 14:59:53.000000000 +0900
@@ -37,10 +37,12 @@
if (tst_kvercmp(2,6,24) < 0)
return 1;+#ifdef HAVE_UNSHARE
ret = unshare(flags);
if ( ret < 0 ) {
printf ("Error:Unshare syscall failed for network
namespace\n");
return 3;
}
+#endif
return 0; }
============
I'm glad if I could get some opinions.
Thank you--
-Tomonori Mitani
------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 49 lines · Mitani
Hi,
I tried to build with "2010-02-10" cvs in my systems.
I tried in RHEL5.4 (2.6.18-164.el5) and RHEL4.8 (2.6.9-89.ELsmp). But "make" failed in "check_netns_enabled.c" as follows in RHEL4.8:
------------
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall(quoted diff) +0
-5-I/home/LTP/ltp-2010-02-10/testcases/kernel/include -I/home/LTP/ltp-2010-02-10/testcases/kernel/containers/netns/../libclone -I../../../../include -I../../../../include -L/home/LTP/ltp-2010-02-10/testcases/kernel/containers/netns/../libclone -L../../../../lib check_netns_enabled.c -lltp -o check_netns_enabled
check_netns_enabled.c: In function `main':
check_netns_enabled.c:40: warning: implicit declaration of function `unshare'
/tmp/cciXlXlf.o(.text+0x2c): In function `main':/home/LTP/ltp-2010-02-10/testcases/kernel/containers/netns/check_netns_enabled.c:40: undefined reference to `unshare'
collect2: ld returned 1 exit status
make[4]: *** [check_netns_enabled] Error 1
make[4]: Leaving directory `/home/LTP/ltp-2010-02-10/testcases/kernel/containers/netns'
------------"
unshare()" function was supported after kernel 2.6.16. Therefore, "make" of "check_netns_enabled.c" failed in RHEL4.8, I think.I made patch and "make" succeeded:
============
---./testcases/kernel/containers/netns/check_netns_enabled.c2008-09-19
21:17:10.000000000 +0900
+++ ./testcases/kernel/containers/netns/check_netns_enabled.c.new2010-02-10 14:59:53.000000000 +0900(quoted diff) +2
-0@@ -37,10 +37,12 @@ if (tst_kvercmp(2,6,24) < 0) return 1; +#ifdef HAVE_UNSHARE ret = unshare(flags); if ( ret < 0 ) { printf ("Error:Unshare syscall failed for network namespace\n"); return 3; } +#endif return 0;}
============
Quoted 1 line
I'm glad if I could get some opinions.
Should be fixed now.
-Garrett
------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 52 lines · Garrett Cooper
Quoted 49 lines · Mitani
Hi,
I tried to build with "2010-02-10" cvs in my systems.
I tried in RHEL5.4 (2.6.18-164.el5) and RHEL4.8 (2.6.9-89.ELsmp). But "make" failed in "check_netns_enabled.c" as follows in RHEL4.8:
------------
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall(quoted diff) +0
-5-I/home/LTP/ltp-2010-02-10/testcases/kernel/include -I/home/LTP/ltp-2010-02-10/testcases/kernel/containers/netns/../libclone -I../../../../include -I../../../../include -L/home/LTP/ltp-2010-02-10/testcases/kernel/containers/netns/../libclone -L../../../../lib check_netns_enabled.c -lltp -o check_netns_enabled
check_netns_enabled.c: In function `main':
check_netns_enabled.c:40: warning: implicit declaration of function `unshare'
/tmp/cciXlXlf.o(.text+0x2c): In function `main':/home/LTP/ltp-2010-02-10/testcases/kernel/containers/netns/check_netns_enabled.c:40: undefined reference to `unshare'
collect2: ld returned 1 exit status
make[4]: *** [check_netns_enabled] Error 1
make[4]: Leaving directory `/home/LTP/ltp-2010-02-10/testcases/kernel/containers/netns'
------------"
unshare()" function was supported after kernel 2.6.16. Therefore, "make" of "check_netns_enabled.c" failed in RHEL4.8, I think.I made patch and "make" succeeded:
============
---./testcases/kernel/containers/netns/check_netns_enabled.c2008-09-19
21:17:10.000000000 +0900
+++ ./testcases/kernel/containers/netns/check_netns_enabled.c.new2010-02-10 14:59:53.000000000 +0900(quoted diff) +2
-0@@ -37,10 +37,12 @@ if (tst_kvercmp(2,6,24)< 0) return 1; +#ifdef HAVE_UNSHARE ret = unshare(flags); if ( ret< 0 ) { printf ("Error:Unshare syscall failed for network namespace\n"); return 3; } +#endif return 0;}
============
Quoted 4 lines
Quoted 2 lines
I'm glad if I could get some opinions.
Should be fixed now.
Thanks,
Rishi
Quoted 10 lines
-Garrett
------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Signature · 15 lines
Thanks& Regards Rishi Kesh K Rajak IBM LTC, Bangalore LTP Maintainer Please join IRC: #ltp @ freenode.net ------------------------------------------------------------------------------ SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list