extcon: max8997: use dev_err() instead of pr_err()
PATCH v2 1/2 extcon: max8997: use dev_err() instead of pr_err()
dev_err() is more preferred than pr_err().
---
No Changes since v1:
drivers/extcon/extcon-max8997.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/extcon/extcon-max8997.c +1 -1
@@ -646,7 +646,7 @@ static void max8997_muic_detect_cable_wq(struct work_struct *work) ret =max8997_muic_detect_dev (info);if (ret <0 ) -pr_err ("failed to detect cable type\n" ); +dev_err (info->dev,"failed to detect cable type\n" ); }static int max8997_muic_probe (struct platform_device *pdev)
Signature · 1 line
1.7.2.5
PATCH v2 2/2 extcon: max8997: add missing const
Fixed the checkpatch warning as below:
WARNING: static const char * array should probably be static const char * const #163: FILE: drivers/extcon/extcon-max8997.c:163:
+static const char *max8997_extcon_cable[] = {
Also, const is added to variable 'supported_cable' to prevent build warning as below:
drivers/extcon/extcon-max8997.c: In function 'max8997_muic_probe':
drivers/extcon/extcon-max8997.c:708:30: warning: assignment discards 'const' qualifier from pointer target type [enabled by
default]
---
Changes since v1:
- Added const to variable 'supported_cable'
drivers/extcon/extcon-max8997.c | 2 +- include/linux/extcon.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/extcon/extcon-max8997.c +1 -1
@@ -160,7 +160,7 @@ enum { _EXTCON_CABLE_NUM, }; -static const char *max8997_extcon_cable[] = { +static const char *const max8997_extcon_cable[] = { [EXTCON_CABLE_USB ] ="USB" , [EXTCON_CABLE_USB_HOST ] ="USB-Host" , [EXTCON_CABLE_TA ] ="TA" ,
include/linux/extcon.h +1 -1
@@ -113,7 +113,7 @@ struct extcon_cable;struct extcon_dev {/* --- Optional user initializing data --- */ const char *name; -const char **supported_cable; +const char *const *supported_cable;const u32 *mutually_exclusive;/* --- Optional callbacks to override class functions --- */
Signature · 1 line
1.7.2.5
Chanwoo Choi
maintainerRe: [PATCH v2 2/2] extcon: max8997: add missing const
Quoted 27 lines · Jingoo Han
Fixed the checkpatch warning as below:
WARNING: static const char * array should probably be static const char * const #163: FILE:
drivers/extcon/extcon-max8997.c:163:
+static const char *max8997_extcon_cable[] = {Also, const is added to variable '
supported_cable' to prevent build warning as below:
drivers/extcon/extcon-max8997.c: In function 'max8997_muic_probe':
drivers/extcon/extcon-max8997.c:708:30: warning: assignment discards 'const' qualifier from pointer target type [enabled by
default]Signed-off-by Jingoo Han <[email protected]>---
Changes since v1:
- Added const to variable 'supported_cable'drivers/extcon/extcon-max8997.c | 2 +- include/linux/extcon.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/extcon/extcon-max8997.c +0
-0
drivers/extcon/extcon-max8997.c enum { · line 163
Quoted 5 lines
drivers/extcon/extcon-max8997.c +1
-1@@ -160,7 +160,7 @@ enum { _EXTCON_CABLE_NUM, }; -static const char *max8997_extcon_cable[] = { +static const char *const max8997_extcon_cable[] = {
OK.
include/linux/extcon.h struct extcon_cable; · line 116
Quoted 13 lines
drivers/extcon/extcon-max8997.c +0
-0[EXTCON_CABLE_USB] = "USB", [EXTCON_CABLE_USB_HOST] = "USB-Host", [EXTCON_CABLE_TA] = "TA",include/linux/extcon.h +1
-1@@ -113,7 +113,7 @@ struct extcon_cable;struct extcon_dev {/* --- Optional user initializing data --- */ const char *name; -const char **supported_cable; +const char *const *supported_cable;
I understand your intention to fix build warning. But, I don't agree this coding style. I think this coding style is not general method.
Thanks,
Chanwoo Choi
RE: [PATCH v2 2/2] extcon: max8997: add missing const
Quoted 36 lines · Chanwoo Choi
Quoted 11 lines · Jingoo Han
Fixed the checkpatch warning as below:
WARNING: static const char * array should probably be static const char * const #163: FILE:
drivers/extcon/extcon-max8997.c:163:
+static const char *max8997_extcon_cable[] = {Also, const is added to variable '
supported_cable' to prevent build warning as below:
drivers/extcon/extcon-max8997.c: In function 'max8997_muic_probe':
drivers/extcon/extcon-max8997.c:708:30: warning: assignment discards 'const' qualifier from pointertarget type [enabled by
Quoted 16 lines
default]
Signed-off-by Jingoo Han <[email protected]>---
Changes since v1:
- Added const to variable 'supported_cable'drivers/extcon/extcon-max8997.c | 2 +- include/linux/extcon.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/extcon/extcon-max8997.c +0
-0drivers/extcon/extcon-max8997.c enum { · line 163
Quoted 5 lines
drivers/extcon/extcon-max8997.c +1
-1@@ -160,7 +160,7 @@ enum { _EXTCON_CABLE_NUM, }; -static const char *max8997_extcon_cable[] = { +static const char *const max8997_extcon_cable[] = {OK.
Quoted 16 lines
include/linux/extcon.h struct extcon_cable; · line 116
Quoted 13 lines
drivers/extcon/extcon-max8997.c +0
-0[EXTCON_CABLE_USB] = "USB", [EXTCON_CABLE_USB_HOST] = "USB-Host", [EXTCON_CABLE_TA] = "TA",include/linux/extcon.h +1
-1@@ -113,7 +113,7 @@ struct extcon_cable;struct extcon_dev {/* --- Optional user initializing data --- */ const char *name; -const char **supported_cable; +const char *const *supported_cable;I understand your intention to fix build warning. But, I don't agree this coding style. I think this coding style is not general method.
Um, how about the following?
In this case, there is no build warning and checkpatch warning.
-static const char *max8997_extcon_cable[] = {
+static char const *max8997_extcon_cable[] = {
Quoted 5 lines
Thanks,
Chanwoo Choi
Quoted 14 lines · Jingoo Han
dev_err()is more preferred thanpr_err().Signed-off-by Jingoo Han <[email protected]>---
No Changes since v1:drivers/extcon/extcon-max8997.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/extcon/extcon-max8997.c +0
-0
drivers/extcon/extcon-max8997.c static void max8997_muic_detect_cable_wq(struct work_struct *work) · line 652
Quoted 8 lines
drivers/extcon/extcon-max8997.c +1
-1@@ -646,7 +646,7 @@ static void max8997_muic_detect_cable_wq(struct work_struct *work) ret =max8997_muic_detect_dev (info);if (ret <0 ) -pr_err ("failed to detect cable type\n" ); +dev_err (info->dev,"failed to detect cable type\n" ); }static int max8997_muic_probe (struct platform_device *pdev)
Applied it. Thanks.
Chanwoo Choi