Build failure with 2010-01-07 cvs

Hi,

I tried to make with latest version (2010-01-07 cvs) in RHEL4.8 (2.6.9-89.ELsmp).
But it failed with following message:
------------
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall

(quoted diff) +0 -4

-I/home/LTP/ltp-2010-01-07/testcases/kernel/include -g
-I/home/LTP/ltp-2010-01-07/testcases/kernel/syscalls/get_mempolicy/../utils
-DNUMA_VERSION1_COMPATIBILITY -I../../../../include -I../../../../include
-L../../../../lib  get_mempolicy01.c   -lltp -lnuma -o get_mempolicy01

In file included from get_mempolicy01.c:78:
/home/LTP/ltp-2010-01-07/testcases/kernel/syscalls/get_mempolicy/../utils/nu ma_helpers.h:81: error: redefinition of 'nodemask_set' /usr/include/numa.h:45: error: previous definition of 'nodemask_set' was here /home/LTP/ltp-2010-01-07/testcases/kernel/syscalls/get_mempolicy/../utils/nu ma_helpers.h:95: error: redefinition of 'nodemask_dump' /home/LTP/ltp-2010-01-07/testcases/kernel/syscalls/get_mempolicy/../utils/nu maif.h:85: error: previous definition of 'nodemask_dump' was here make[4]: *** [get_mempolicy01] Error 1
------------

"numa_helpers.h" is as follows (comments are omitted):
------------
#ifndef LTP_NUMA_HELPERS_H
#define LTP_NUMA_HELPERS_H

#include "config.h"
#if HAVE_NUMA_H
#include <numa.h>

static inline void nodemask_set(nodemask_t *mask, int node)

{                                                       <----- L.81 mask->n[node / (8*sizeof(unsigned long))] |=
               (1UL << (node % (8*sizeof(unsigned long)))); }

static inline void nodemask_dump(const char *header, const nodemask_t *mask) {                                                       <----- L.95 int i;
       EPRINTF("%s", header);
       for (i = 0; i < NUMA_NUM_NODES/(sizeof(unsigned long)*8); i++) EPRINTF(" 0x%08lx", mask->n[i]);
       EPRINTF("\n");
}

#else

typedef struct nodemask_t { };

static inline void nodemask_set(nodemask_t *mask, int node) {
       return;
}

static inline void nodemask_dump(const char *header, const nodemask_t *mask) {
       return;
}

#endif

#endif
------------

In my system, HAVE_NUMA_H is defined as 1.

The function "nodemask_set" defined in "/usr/include/numa.h" is same as the one of "numa_helpers.h".
And the function "nodemask_dump" defined in "${LTPROOT}/testcases/kernel /syscalls/utils/numa_helpers" is same as the one of "numa_helpers.h".

Why are the same definitions necessary in "numa_helpers.h" on purpose?

I'm glad if I get your help.

Quoted 74 lines · Mitani

Hi,

I tried to make with latest version (2010-01-07 cvs) in RHEL4.8 (2.6.9-89.ELsmp).
But it failed with following message:
------------
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall

(quoted diff) +0 -4

-I/home/LTP/ltp-2010-01-07/testcases/kernel/include -g
-I/home/LTP/ltp-2010-01-07/testcases/kernel/syscalls/get_mempolicy/../utils
-DNUMA_VERSION1_COMPATIBILITY -I../../../../include -I../../../../include
-L../../../../lib  get_mempolicy01.c   -lltp -lnuma -o get_mempolicy01

In file included from get_mempolicy01.c:78:
/home/LTP/ltp-2010-01-07/testcases/kernel/syscalls/get_mempolicy/../utils/nu ma_helpers.h:81: error: redefinition of 'nodemask_set' /usr/include/numa.h:45: error: previous definition of 'nodemask_set' was here /home/LTP/ltp-2010-01-07/testcases/kernel/syscalls/get_mempolicy/../utils/nu ma_helpers.h:95: error: redefinition of 'nodemask_dump' /home/LTP/ltp-2010-01-07/testcases/kernel/syscalls/get_mempolicy/../utils/nu maif.h:85: error: previous definition of 'nodemask_dump' was here make[4]: *** [get_mempolicy01] Error 1
------------

"numa_helpers.h" is as follows (comments are omitted):
------------
#ifndef LTP_NUMA_HELPERS_H
#define LTP_NUMA_HELPERS_H

#include "config.h"
#if HAVE_NUMA_H
#include <numa.h>

static inline void nodemask_set(nodemask_t *mask, int node)

{ <----- L.81

       mask->n[node / (8*sizeof(unsigned long))] |=
               (1UL << (node % (8*sizeof(unsigned long))));
}

static inline void nodemask_dump(const char *header, const nodemask_t *mask)
{ <----- L.95

       int i;
       EPRINTF("%s", header);
       for (i = 0; i < NUMA_NUM_NODES/(sizeof(unsigned long)*8); i++)
               EPRINTF(" 0x%08lx", mask->n[i]);
       EPRINTF("\n");
}

#else

typedef struct nodemask_t { };

static inline void nodemask_set(nodemask_t *mask, int node)

{
       return;
}

static inline void nodemask_dump(const char *header, const nodemask_t *mask)

{
       return;
}

#endif

#endif
------------

In my system, HAVE_NUMA_H is defined as 1.

The function "nodemask_set" defined in "/usr/include/numa.h" is same as the one of "numa_helpers.h".
And the function "nodemask_dump" defined in "${LTPROOT}/testcases/kernel /syscalls/utils/numa_helpers" is same as the one of "numa_helpers.h".

Quoted 4 lines

Why are the same definitions necessary in "numa_helpers.h" on purpose?

I'm glad if I get your help.

Try now please.
Thanks,
-Garrett

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list