fix "clock_getcpuclockid/5-1" test

PATCH In review Mitani 2 participants 2 messages Nov 11, 2010

lore

Share & tools

lore

Mitani

author

2010-11-11 02:17 UTC #0 lore raw

PATCH 1/1 fix "clock_getcpuclockid/5-1" test

Hi,

Build of POSIX "conformance/interfaces/clock_getcpuclockid/5-1.c" test failed
with following message:
------------
conformance/interfaces/clock_getcpuclockid/5-1 compile FAILED; SKIPPING ../../../conformance/interfaces/clock_getcpuclockid/5-1.c: In function 'main':
../../../conformance/interfaces/clock_getcpuclockid/5-1.c:54: error:
expected ';' before 'if'
------------

Environment is as follows:
- RHEL5.5 (kernel version 2.6.18-194) --- (x86, x86_64, ia64)
- RHEL4.8 (kernel version 2.6.18-194) --- (x86, x86_64, ia64)

I noticed some mistakes.

Signed-off-by Tomonori Mitani <[email protected]>

============
---
a/testcases/open_posix_testsuite/conformance/interfaces/clock_getcpuclockid/
5-1.c 2010-11-09 19:00:43.000000000 +0900
+++
b/testcases/open_posix_testsuite/conformance/interfaces/clock_getcpuclockid/
5-1.c 2010-11-11 10:00:47.000000000 +0900
@@ -50,14 +50,14 @@
}

/* Try and get the cpu clock ID for init(1) :)... */
- error = clock_getcpuclockid(1, &clockid_1)
+ error = clock_getcpuclockid(1, &clockid_1);
if (error == 0) {
printf("clock_getcpuclockid(1, ..) passed unexpectedly\n"); return PTS_UNRESOLVED;
} else if (error != EPERM) {
printf("clock_getcpuclockid(1, ..) failed with an improper "
"error (%d != %d)\n", EPERM, error);
- return PTS_FAILED;
+ return PTS_FAIL;
}
printf("Test PASSED\n");
return PTS_PASS;
============

Thank you--

-Tomonori Mitani

testcases/open_posix_testsuite/conformance/interfaces/clock_getcpuclockid/5-1.c +2 -2

@@ -50,14 +50,14 @@
 	}
 
 	/* Try and get the cpu clock ID for init(1) :)... */
-	error = clock_getcpuclockid(1, &clockid_1)
+	error = clock_getcpuclockid(1, &clockid_1);
 	if (error == 0) {
 		printf("clock_getcpuclockid(1, ..) passed unexpectedly\n");
 		return PTS_UNRESOLVED;
 	} else if (error != EPERM) {
 		printf("clock_getcpuclockid(1, ..) failed with an improper "
 			"error (%d != %d)\n", EPERM, error);
-		return PTS_FAILED;
+		return PTS_FAIL;
 	}
 	printf("Test PASSED\n");
 	return PTS_PASS;

------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Garrett Cooper

2010-11-11 03:02 UTC #1 lore raw

2010/11/10 Mitani <[email protected]>:

Quoted 38 lines

Hi,
Build of POSIX "conformance/interfaces/clock_getcpuclockid/5-1.c" test failed
with following message:
------------
conformance/interfaces/clock_getcpuclockid/5-1 compile FAILED; SKIPPING ../../../conformance/interfaces/clock_getcpuclockid/5-1.c: In function 'main':
../../../conformance/interfaces/clock_getcpuclockid/5-1.c:54: error:
expected ';' before 'if'
------------
Environment is as follows:
- RHEL5.5 (kernel version 2.6.18-194) --- (x86, x86_64, ia64)
- RHEL4.8 (kernel version 2.6.18-194) --- (x86, x86_64, ia64)
I noticed some mistakes.
Signed-off-by Tomonori Mitani <[email protected]>
============
---
a/testcases/open_posix_testsuite/conformance/interfaces/clock_getcpuclockid/ 5-1.c 2010-11-09 19:00:43.000000000 +0900
+++
b/testcases/open_posix_testsuite/conformance/interfaces/clock_getcpuclockid/ 5-1.c 2010-11-11 10:00:47.000000000 +0900
testcases/open_posix_testsuite/conformance/interfaces/clock_getcpuclockid/5-1.c +1 -1
@@ -50,14 +50,14 @@
        }
 
        /* Try and get the cpu clock ID for init(1) :)... */
-       error = clock_getcpuclockid(1, &clockid_1)
+       error = clock_getcpuclockid(1, &clockid_1);
        if (error == 0) {
                printf("clock_getcpuclockid(1, ..) passed unexpectedly\n");
                return PTS_UNRESOLVED;
        } else if (error != EPERM) {

Quoted 7 lines

printf("clock_getcpuclockid(1, ..) failed with an improper " "error (%d != %d)\n", EPERM, error);
- return PTS_FAILED;
+ return PTS_FAIL;
}
printf("Test PASSED\n");
return PTS_PASS;

Yeah... I probably committed some WIP code. Patch committed.
Thanks!
-Garrett