logrotate: /var/log/messages* disappeared
PATCH 1/1 logrotate: /var/log/messages* disappeared
Hi,
I found a problem on LTP when I execute ./runltp.
After execute ./runltp, all log files such as /var/log/messages* disappeared,
and there is only new log files that were created after the test...
This seems a problem that occurs after the "logrotate01" test.
I found that the past log files disappeared by forcing a rotate (logrotate -fv $LTPTMP/tst_logrotate.conf).
Besides, "logrotate"'s shell script ./testcases/commands/logrotate/logrotate_tests.sh creats
logrotate configuration file ($LTPTMP/tst_logrotate.conf) for the test, and this config file includes
/etc/logrotate.d as follows:
[ ./testcases/commands/logrotate/logrotate_tests.sh line:156~ ]
----------
# create config file.
cat >$LTPTMP/tst_logrotate.conf <<-EOF
#****** Begin Config file *******
# create new (empty) log files after rotating old ones
create
# compress the log files
compress
# RPM packages drop log rotation information into this
directory
include /etc/logrotate.d
/var/log/tst_logfile {
rotate 5
weekly
}
#****** End Config file *******
EOF----------
By this, not only a log file for the test (/var/log/tst_logfile), but also 30 fies in my system
such as /var/log/messages* become "logrotate" command target.
Therefore, only a log file for this test must be made a target of the forced execution of "logrotate".
To resolve this problem, we have to change this not to include /etc/logrotate.d, I think.
Index: testcases/commands/logrotate/logrotate_tests.sh
==============================
--- logrotate_tests.sh 2008-10-21 15:54:15.000000000 +0900
+++ logrotate_tests.sh.new 2010-02-05 18:56:14.000000000 +0900
@@ -163,7 +163,7 @@
compress
# RPM packages drop log rotation information into this
directory
- include /etc/logrotate.d
+ # include /etc/logrotate.d
/var/log/tst_logfile {
rotate 5@@ -200,7 +200,7 @@
# check if /etc/logrotate.d is included/
# check if 5 rotations are forced.
# check if compression is done.
- grep "including /etc/logrotate.d"
$LTPTMP/tst_logrotate.out \
+ # grep "including /etc/logrotate.d"
$LTPTMP/tst_logrotate.out \
> $LTPTMP/tst_logrotate.err 2>&1 ||
RC=$?
grep "reading config file$LTPTMP/tst_logrotate.conf" \
$LTPTMP/tst_logrotate.out >
$LTPTMP/tst_logrotate.err 2>&1 || RC=$?
Thank you,
--Yuki Yao
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Sorry, line breaks is mistake; resend.
----------------------------------------------------
Hi,
I found a problem on LTP when I execute ./runltp.
After execute ./runltp, all log files such as /var/log/messages* disappeared,
and there is only new log files that were created after the test...
This seems a problem that occurs after the "logrotate01" test. I found that the past log files disappeared by forcing a rotate (logrotate -fv $LTPTMP/tst_logrotate.conf).
Besides, "logrotate"'s shell script ./testcases/commands/logrotate/logrotate_tests.sh creats logrotate configuration file ($LTPTMP/tst_logrotate.conf) for the test, and this config file includes/etc/logrotate.d as follows:
[ ./testcases/commands/logrotate/logrotate_tests.sh line:156~ ]
----------
# create config file. cat >$LTPTMP/tst_logrotate.conf <<-EOF #****** Begin Config file ******* # create new (empty) log files after rotating old ones create
# compress the log files compress
# RPM packages drop log rotation information into this directory
include /etc/logrotate.d
/var/log/tst_logfile {
rotate 5
weekly
}
#****** End Config file *******
EOF----------
By this, not only a log file for the test (/var/log/tst_logfile), but also 30 fies in my system
such as /var/log/messages* become "logrotate" command target. Therefore, only a log file for this test must be made a target of the forced execution of "logrotate".
To resolve this problem, we have to change this not to include /etc/logrotate.d, I think.
logrotate_tests.sh.new renamed from logrotate_tests.sh +2 -2
@@ -163,7 +163,7 @@ compress # RPM packages drop log rotation information into this directory - include /etc/logrotate.d + # include /etc/logrotate.d /var/log/tst_logfile { rotate 5
@@ -200,7 +200,7 @@ # check if /etc/logrotate.d is included/ # check if 5 rotations are forced. # check if compression is done. - grep "including /etc/logrotate.d" $LTPTMP/tst_logrotate.out + # grep "including /etc/logrotate.d"
$LTPTMP/tst_logrotate.out \
> $LTPTMP/tst_logrotate.err 2>&1 || RC=$?
grep "reading config file $LTPTMP/tst_logrotate.conf" \
$LTPTMP/tst_logrotate.out >
$LTPTMP/tst_logrotate.err 2>&1 || RC=$?
Thank you,
--Yuki Yao
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 2 lines · Yuki Yao
Sorry, line breaks is mistake; resend.
Hi Yuki Yao,
Few nits:
I would appreciate if you append your Signed-off and resend once again.
Then i will provide my review comment. And in future please create your patch against LTPROOT/ dir.
Thanks
Rishi
Quoted 79 lines
----------------------------------------------------
Hi,I found a problem on LTP when I execute ./runltp.
After execute ./runltp, all log files such as/var/log/messages*disappeared,
and there is only new log files that were created after the test...This seems a problem that occurs after the "logrotate01" test. I found that the past log files disappeared by forcing a rotate (logrotate -fv
$LTPTMP/tst_logrotate.conf).Besides, "logrotate"'s shell script
./testcases/commands/logrotate/logrotate_tests.shcreats logrotate configuration file ($LTPTMP/tst_logrotate.conf) for the test, and this config file includes/etc/logrotate.das follows:
[./testcases/commands/logrotate/logrotate_tests.shline:156~ ]
----------# create config file. cat>$LTPTMP/tst_logrotate.conf<<-EOF #****** Begin Config file ******* # create new (empty) log files after rotating old ones create# compress the log files compress# RPM packages drop log rotation information into this directory include /etc/logrotate.d /var/log/tst_logfile { rotate 5 weekly } #****** End Config file ******* EOF----------
By this, not only a log file for the test (
/var/log/tst_logfile), but also 30 fies in my system
such as/var/log/messages*become "logrotate" command target. Therefore, only a log file for this test must be made a target of the forced execution of "logrotate".To resolve this problem, we have to change this not to include
/etc/logrotate.d, I think.Index:
testcases/commands/logrotate/logrotate_tests.sh
==============================logrotate_tests.sh.new renamed from logrotate_tests.sh +2
-2@@ -163,7 +163,7 @@ compress # RPM packages drop log rotation information into this directory - include /etc/logrotate.d + # include /etc/logrotate.d /var/log/tst_logfile { rotate 5@@ -200,7 +200,7 @@ # check if /etc/logrotate.d is included/ # check if 5 rotations are forced. # check if compression is done. - grep "including /etc/logrotate.d" $LTPTMP/tst_logrotate.out \ + # grep "including /etc/logrotate.d" $LTPTMP/tst_logrotate.out \ > $LTPTMP/tst_logrotate.err 2>&1 || RC=$?grep "reading config file
$LTPTMP/tst_logrotate.conf" \
$LTPTMP/tst_logrotate.out>
$LTPTMP/tst_logrotate.err 2>&1 || RC=$?Thank you,
--Yuki Yao
Quoted 11 lines
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list