fix "su01" test

Hi,

I ran "su01" test.
This test failed:
------------<log>
userdel: user su_usr1 does not exist
Creating mailbox file: File exists
userdel: user su_usr2 does not exist
Creating mailbox file: File exists
YOU NEED TO SET ENVIROMENT VARIABLE PASSWD.
------------

This failure was caused by "PASSWD" environment variable not being set:
------------<su01_s1>
#Grab input from enviroment
if [info exists env(PASSWD)] {
       set PASSWD $env(PASSWD)
} else {
       send_user "YOU NEED TO SET ENVIROMENT VARIABLE PASSWD. \n" exit 1
}
------------

According to "su01_s1", this "PASSWD" is the password of "root" user:
------------<su01_s1>
spawn /bin/su -c whoami
set i_am_root 0
expect {
 "Password:" {
       send "$PASSWD\r"
   expect {
     "root" { set i_am_root 1
               set i_can_root 1
        }
   }
 }
}
------------

I think whether this test program is unfinished.
Probably the author of this program thought that there was a problem to set a password in the shell, I think.
Because, the password of root is various by each users who run the test, and it cannot be gotten from environment variable or file etc.

So, I suggest that "su01" shell demands root password when it is run. But, when user forgot to input, it should return and finish with error.

I attach the patch for "su01" file.

Quoted 45 lines · Mitani

Hi,

I ran "su01" test.
This test failed:
------------<log>
userdel: user su_usr1 does not exist
Creating mailbox file: File exists
userdel: user su_usr2 does not exist
Creating mailbox file: File exists
YOU NEED TO SET ENVIROMENT VARIABLE PASSWD.
------------

This failure was caused by "PASSWD" environment variable not being set:
------------<su01_s1>
#Grab input from enviroment
if [info exists env(PASSWD)] {
       set PASSWD $env(PASSWD)
} else {
       send_user "YOU NEED TO SET ENVIROMENT VARIABLE PASSWD. \n" exit 1
}
------------

According to "su01_s1", this "PASSWD" is the password of "root" user:
------------<su01_s1>
spawn /bin/su -c whoami
set i_am_root 0
expect {
 "Password:" {
       send "$PASSWD\r"
   expect {
     "root" { set i_am_root 1
               set i_can_root 1
        }
   }
 }
}
------------

I think whether this test program is unfinished.
Probably the author of this program thought that there was a problem to set a password in the shell, I think.
Because, the password of root is various by each users who run the test, and it cannot be gotten from environment variable or file etc.

Quoted 5 lines

So, I suggest that "su01" shell demands root password when it is run. But, when user forgot to input, it should return and finish with error.

I attach the patch for "su01" file.

   I don't agree; this item is already mentioned in INSTALL (but I think that it should probably be moved to a README file or something... INSTALL doesn't seem intuitive) for another set of tests:

   iv) Finally, before running the networktests.sh script, two variables must be set within the script file.  The "RHOST" variable should be set to the hostname of the server.  The "PASSWD" variable should be set to root's password on the server machine.  This is necessary for tests such as telnet01 and ftp01.

   All of the applications which require $PASSWD need to be documented though as this is far from intuitive.

-----Original Message-----
From: Garrett Cooper [mailto:[email protected]]
Sent: Tuesday, April 20, 2010 3:46 PM
To: Mitani
Cc: [email protected]; [email protected]
Subject: Re: [LTP] [PATCH] fix "su01" test

Quoted 13 lines · Garrett Cooper

Quoted 12 lines · Mitani

Hi,

I ran "su01" test.
This test failed:
------------<log>
userdel: user su_usr1 does not exist
Creating mailbox file: File exists
userdel: user su_usr2 does not exist
Creating mailbox file: File exists
YOU NEED TO SET ENVIROMENT VARIABLE PASSWD.
------------

Quoted 1 line

Quoted 1 line

This failure was caused by "PASSWD" environment variable not being

set:

Quoted 11 lines

Quoted 11 lines

------------<su01_s1>
#Grab input from enviroment
if [info exists env(PASSWD)] {
       set PASSWD $env(PASSWD)
} else {
       send_user "YOU NEED TO SET ENVIROMENT VARIABLE PASSWD. \n" exit 1
}
------------

According to "su01_s1", this "PASSWD" is the password of "root"

user:

Quoted 15 lines

Quoted 15 lines

------------<su01_s1>
spawn /bin/su -c whoami
set i_am_root 0
expect {
 "Password:" {
       send "$PASSWD\r"
   expect {
     "root" { set i_am_root 1
               set i_can_root 1
        }
   }
 }
}
------------

Quoted 4 lines

Quoted 4 lines

I think whether this test program is unfinished.
Probably the author of this program thought that there was a problem to set a password in the shell, I think.
Because, the password of root is various by each users who run the

test,

Quoted 3 lines

Quoted 3 lines

and it cannot be gotten from environment variable or file etc.

So, I suggest that "su01" shell demands root password when it is

run.

Quoted 1 line

Quoted 1 line

But, when user forgot to input, it should return and finish with

error.

Quoted 5 lines

Quoted 3 lines

I attach the patch for "su01" file.

   I don't agree; this item is already mentioned in INSTALL (but

I

Quoted 2 lines

think that it should probably be moved to a README file or something... INSTALL doesn't seem intuitive) for another set of

tests:

Quoted 2 lines

   iv) Finally, before running the networktests.sh script, two

variables must

Quoted 1 line

       be set within the script file.  The "RHOST" variable should

be set to

Quoted 1 line

       the hostname of the server.  The "PASSWD" variable should

be set to

Quoted 1 line

       root's password on the server machine.  This is necessary

for tests

Quoted 4 lines

       such as telnet01 and ftp01.

   All of the applications which require $PASSWD need to be documented though as this is far from intuitive.

Also, what you're suggesting would fix _interactive_ tests, not
_non-interactive_ tests, where the majority of all users should *not* be running LTP interactively -- thus I don't think that it's a worthwhile addition (sorry :(...).
Thanks,
-Garrett

Sorry.

I understand.
I was careless.