About ARECA RAID driver for Linux i386/x86-64
Quoted 4 lines · erich
Hi,Andrew Morton
I had clean up "arcmsr" for linux kernel 2.6.10.
May be it looks more cleanly than old version.
Sorry, but I don't see that much of a difference ;-)
To get the driver into a shape where we can actually start a review, do run the shell script scripts/Lindent from the kernel tree over the driver, and please kill all your SHOUTING typedefs for kernel types. After that compare it with the file Documentation/CodingStyle, also in the kernel tree and try to fix up whatever seems to not match up.
Quoted 8 lines · Linux Christoph Hellwig
Quoted 4 lines · erich
Hi,Andrew Morton
I had clean up "arcmsr" for linux kernel 2.6.10.
May be it looks more cleanly than old version.Sorry, but I don't see that much of a difference ;-)
All the LINUX_VERSION_CODE tests went away.
Quoted 3 lines
To get the driver into a shape where we can actually start a review, do run the shell script
scripts/Lindentfrom the kernel tree over the driver,
yup. three seconds work.
Quoted 2 lines
and please kill
all your SHOUTING typedefs for kernel types.
Yes, these:
+typedef int8_t CHAR, *PCHAR;
+typedef int16_t SHORT, *PSHORT;
+typedef int32_t LONG32, *PLONG32;
+typedef int64_t LONG64, *PLONG64;
+typedef uint8_t UCHAR, *PUCHAR;
+typedef uint16_t USHORT, *PUSHORT;
+typedef uint32_t ULONG32, *PULONG32;
+typedef uint64_t ULONG64, *PULONG64;
+typedef Scsi_Device SCSIDEV, *PSCSIDEV;
+typedef Scsi_Cmnd SCSICMD, *PSCSICMD;
+typedef void VOID, *PVOID;
+typedef struct Scsi_Host SH, *PSH;
+typedef struct scatterlist SGL, *PSGL;
+typedef void (*DPCFUN) (void *);
+typedef struct _MU MU, *PMU;
+typedef struct _CCB CCB, *PCCB;
+typedef struct _ACB ACB, *PACB;
+typedef struct _HCBARC HCBARC, *PHCBARC;
+typedef struct _DPC DPC, *PDPC;
+typedef struct _EVENT EVENT, *PEVENT;
+typedef struct _QBUFFER QBUFFER, *PQBUFFER;
+typedef struct _SG32ENTRY SG32ENTRY, *PSG32ENTRY; +typedef struct _SG64ENTRY SG64ENTRY, *PSG64ENTRY; +typedef struct _SGENTRY_UNION SGENTRY_UNION, PSGENTRY_UNION; +typedef struct _SYSTEMTIME SYSTEMTIME, *PSYSTEMTIME; +typedef struct _TIMERECORD TIMERECORD, *PTIMERECORD; +typedef struct _SENSE_DATA SENSE_DATA, *PSENSE_DATA; +typedef struct _ARCMSR_PCIINFO ARCMSR_PCIINFO, *PARCMSR_PCIINFO; +typedef struct _ARCMSR_CDB ARCMSR_CDB, *PARCMSR_CDB; +typedef struct _CMD_IO_CONTROL CMD_IO_CONTROL, *PCMD_IO_CONTROL; +typedef struct _CMD_IOCTL_FIELD CMD_IOCTL_FIELD, *PCMD_IOCTL_FIELD; +#if defined(__x86_64__)
+typedef uint64_t CPT2INT, *PCPT2INT;
+#else
+typedef uint32_t CPT2INT, *PCPT2INT;
+#endif
should be removed - just open-code the types within the .c code.