Skip to contentSkip to conversation

u-boot_git: Ethernet MACID display fix for CraneBoard

PATCH Anil Kumar Mamidala 1 participant 1 message May 6, 2011 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 000a01cc0bc4$3277cf70$97676e50$@com

#1 lore raw

Hi Paul,

Thanks for your quick feedback. I am sorry. From my next submissions i will keep your comments in mind.

Here is my Signed-off .

This patch was not send to upstream.

Quoted 46 lines

Dear Anil,

thank you for the next version.

Am Freitag, den 06.05.2011, 12:45 +0530 schrieb Anil Kumar:

Quoted 3 lines

CraneBoard u-boot displays the MAC ID wrongly if MAC ID has
preceding zeros. This patch fixes it and updates Ethernet NRST GPIO from 34 to 65.

Unfortunately you forgot to add your Signed-off-by line. You do not need to resend the patch, but just reply to this message with the line.

One question though you did not answer.

1. Did you send this patch upstream?

Some more remarks for the future.

2. Please mark patch iteration with version information. This patch should have had »[PATCH v2]« in the subject.
3. The commit message does not have to be indented.
4. Please add below the »---« a short information what changed in the patch iteration, like

v2: add commit message
and finish this by an additional »---«.

Quoted 2 lines
---
 ...t-MACID-display-fix-for-am3517-craneboard.patch |  108

++++++++++++++++++++

Quoted 5 lines
 recipes/u-boot/u-boot_git.bb                       |    3 +-
 2 files changed, 110 insertions(+), 1 deletions(-)  create mode

100644 recipes/u-boot/u-boot-git/am3517-crane/0004-Ethernet-MACID-display-fix -for-am3517-craneboard.patch

[…]

Koen, will you push this or do you want me to do this?

Thank you,

Paul

Signature · 2 lines
Thanks and Regards
Anil kumar.M