Skip to contentSkip to conversation

backlight: platform-lcd: Add support for device tree based probe

PATCH In review Jingoo Han 2 participants 2 messages Sep 21, 2012

Subsystems (2)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 backlight: platform-lcd: Add support for device tree based probe

This patch adds the of_match_table to platform-lcd driver to be probed when platform-lcd device node is found in the device tree.

Cc Richard Purdie <[email protected]>
---
 drivers/video/backlight/platform_lcd.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
drivers/video/backlight/platform_lcd.c +9 -0
index b667234..574d5ee 100644
@@ -145,6 +145,14 @@ static SIMPLE_DEV_PM_OPS(platform_lcd_pm_ops, platform_lcd_suspend,
 			platform_lcd_resume);
 #endif
 
+#ifdef CONFIG_OF
+static const struct of_device_id platform_lcd_of_match[] = {
+	{ .compatible = "platform-lcd" },
+	{},
+};
+MODULE_DEVICE_TABLE(of, platform_lcd_of_match);
+#endif
+
 static struct platform_driver platform_lcd_driver = {
 	.driver		= {
 		.name	= "platform-lcd",
@@ -152,6 +160,7 @@ static struct platform_driver platform_lcd_driver = {
 #ifdef CONFIG_PM
 		.pm	= &platform_lcd_pm_ops,
 #endif
+		.of_match_table = of_match_ptr(platform_lcd_of_match),
 	},
 	.probe		= platform_lcd_probe,
 	.remove		= __devexit_p(platform_lcd_remove),
Signature · 1 line
1.7.1
#1 lore raw
Quoted 29 lines · On Fri, 21 Sep 2012 10:27:07 +0900 Jingoo Han <[email protected]> wrote:

This patch adds the of_match_table to platform-lcd driver to be probed when platform-lcd device node is found in the device tree.

Cc Richard Purdie <[email protected]>
---
 drivers/video/backlight/platform_lcd.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
drivers/video/backlight/platform_lcd.c +8 -0
index b667234..574d5ee 100644
@@ -145,6 +145,14 @@ static SIMPLE_DEV_PM_OPS(platform_lcd_pm_ops, platform_lcd_suspend,
 			platform_lcd_resume);
 #endif
 
+#ifdef CONFIG_OF
+static const struct of_device_id platform_lcd_of_match[] = {
+	{ .compatible = "platform-lcd" },
+	{},
+};
+MODULE_DEVICE_TABLE(of, platform_lcd_of_match);
+#endif
+
 static struct platform_driver platform_lcd_driver = {
 	.driver		= {
 		.name	= "platform-lcd",

drivers/video/backlight/platform_lcd.c static struct platform_driver platform_lcd_driver = { · line 166

Quoted 7 lines
drivers/video/backlight/platform_lcd.c +1 -0
@@ -152,6 +160,7 @@ static struct platform_driver platform_lcd_driver = {
 #ifdef CONFIG_PM
 		.pm	= &platform_lcd_pm_ops,
 #endif
+		.of_match_table = of_match_ptr(platform_lcd_of_match),
 	},
 	.probe		= platform_lcd_probe,
 	.remove		= __devexit_p(platform_lcd_remove),

This .c file includes no open-firmware headers.

It does happen to get a copy of of.h via fb.h->i2c.h->of.h, but that was just luck.

I did this:

drivers/video/backlight/platform_lcd.c renamed from drivers/video/backlight/platform_lcd.c~backlight-platform-lcd-add-support-for-device-tree-based-probe-fix +1 -0
@@ -16,6 +16,7 @@
 #include <linux/fb.h>
 #include <linux/backlight.h>
 #include <linux/lcd.h>
+#include <linux/of.h>
 #include <linux/slab.h>
 
 #include <video/platform_lcd.h>

_