f2fs: remove debufs dir if debugfs_create_file() failed
Hi Liu,
You're right, we should release it instead of holding the resource with no use. And here are some comments as following.
BTW, your patch is out of format. You'd better not let remote terminal or editor to instead tab with blanks in the patch.
Thanks,
Yu
Quoted 35 lines
-----Original Message-----
From: Younger Liu [mailto:[email protected]]
Sent: Monday, December 02, 2013 9:16 PM
To: Jaegeuk Kim
Cc: fs-devel; kernel; f2fs
Subject: [f2fs-dev] [PATCH 0/2] f2fs: remove debufs dir ifdebugfs_create_file()failedFrom: Younger Liu <[email protected]>
When
debugfs_create_file()failed inf2fs_create_root_stats(),debugfs_rootshould be removed.Signed-off-by Younger Liu <[email protected]>Cc Younger Liu <[email protected]>Cc Jaegeuk Kim <[email protected]>--- fs/f2fs/debug.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-)fs/f2fs/debug.c +4
-3@@ -340,10 +340,24 @@ void f2fs_destroy_stats(struct f2fs_sb_info *sbi)void __init f2fs_create_root_stats (void ) { +struct dentry *file; + debugfs_root =debugfs_create_dir ("f2fs" ,NULL ); -if (debugfs_root) -debugfs_create_file ("status" ,S_IRUGO , debugfs_root, -NULL , &stat_fops); +if (!debugfs_root) + goto bail;
fs/f2fs/debug.c void f2fs_destroy_stats(struct f2fs_sb_info *sbi) · line 357
Quoted 10 lines
fs/f2fs/debug.c +10
-0+ + file =debugfs_create_file ("status" ,S_IRUGO , + debugfs_root,NULL , &stat_fops); +if (!file) + goto free_debugfs_dir; + +return ; + +free_debugfs_dir: +debugfs_remove (debugfs_root);
debugfs_root = NULL;
fs/f2fs/debug.c void f2fs_destroy_stats(struct f2fs_sb_info *sbi) · line 363
Quoted 6 lines
fs/f2fs/debug.c +3
-0+ +bail: +return ; }void f2fs_destroy_root_stats (void )
You should judge debugfs_root value in f2fs_destroy_root_stats to decide free or not.
Quoted 15 lines
--
1.7.9.5------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 10 lines · Chao Yu
Hi Liu,
You're right, we should release it instead of holding the resource with no use. And here are some comments as following.
BTW, your patch is out of format. You'd better not let remote terminal or editor to instead tab with blanks in the patch.
Thanks,
Yu
Hi Yu,
thanks for your review. I will modify the patch
and resent in a moment.
Quoted 72 lines
Quoted 35 lines
-----Original Message-----
From: Younger Liu [mailto:[email protected]]
Sent: Monday, December 02, 2013 9:16 PM
To: Jaegeuk Kim
Cc: fs-devel; kernel; f2fs
Subject: [f2fs-dev] [PATCH 0/2] f2fs: remove debufs dir ifdebugfs_create_file()failedFrom: Younger Liu <[email protected]>
When
debugfs_create_file()failed inf2fs_create_root_stats(),debugfs_rootshould be removed.Signed-off-by Younger Liu <[email protected]>Cc Younger Liu <[email protected]>Cc Jaegeuk Kim <[email protected]>--- fs/f2fs/debug.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-)fs/f2fs/debug.c +4
-3@@ -340,10 +340,24 @@ void f2fs_destroy_stats(struct f2fs_sb_info *sbi)void __init f2fs_create_root_stats (void ) { +struct dentry *file; + debugfs_root =debugfs_create_dir ("f2fs" ,NULL ); -if (debugfs_root) -debugfs_create_file ("status" ,S_IRUGO , debugfs_root, -NULL , &stat_fops); +if (!debugfs_root) + goto bail;fs/f2fs/debug.c void f2fs_destroy_stats(struct f2fs_sb_info *sbi) · line 357
Quoted 10 lines
fs/f2fs/debug.c +10
-0+ + file =debugfs_create_file ("status" ,S_IRUGO , + debugfs_root,NULL , &stat_fops); +if (!file) + goto free_debugfs_dir; + +return ; + +free_debugfs_dir: +debugfs_remove (debugfs_root);
debugfs_root= NULL;fs/f2fs/debug.c void f2fs_destroy_stats(struct f2fs_sb_info *sbi) · line 363
Quoted 6 lines
fs/f2fs/debug.c +3
-0+ +bail: +return ; }void f2fs_destroy_root_stats (void )You should judge
debugfs_rootvalue inf2fs_destroy_root_statsto decide free or not.Quoted 5 lines
--
1.7.9.5Quoted 10 lines
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 12 lines
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk