Skip to contentSkip to conversation

Microcode: show results on success too plus fix typo

PATCH In review Ben Castricum 4 participants 4 messages Mar 26, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Microcode: show results on success too plus fix typo

Show a bit more info when updating microcode. It used to be there but no with DEBUG unset makes it very silent.

This is my first patch, please let me know if I did anything wrong.

arch/x86/kernel/microcode.c +2 -2
index f2702d0..ca1fd52 100644
@@ -336,11 +336,11 @@ static void apply_microcode(int cpu)
 
 spin_unlock_irqrestore(&microcode_update_lock, flags);
 if (val[1] != uci->mc->hdr.rev) {
-  printk(KERN_ERR "microcode: CPU%d updated from revision "
+  printk(KERN_ERR "microcode: CPU%d update from revision "
   "0x%x to 0x%x failed\n", cpu_num, uci->rev, val[1]);
  return;
 }
- pr_debug("microcode: CPU%d updated from revision "
+ printk(KERN_INFO "microcode: CPU%d updated from revision "
        "0x%x to 0x%x, date = %08x \n",
        cpu_num, uci->rev, val[1], uci->mc->hdr.date);
 uci->rev = val[1];
#1 lore raw
Quoted 15 lines · On Wed, 26 Mar 2008 21:22:25 +0100 Ben Castricum wrote:

Show a bit more info when updating microcode. It used to be there but no with DEBUG unset makes it very silent.

This is my first patch, please let me know if I did anything wrong.

arch/x86/kernel/microcode.c +0 -0
index f2702d0..ca1fd52 100644
@@ -336,11 +336,11 @@ static void apply_microcode(int cpu)
 
  spin_unlock_irqrestore(&microcode_update_lock, flags);
  if (val[1] != uci->mc->hdr.rev) {

arch/x86/kernel/microcode.c static void apply_microcode(int cpu) · line 346

Quoted 10 lines
arch/x86/kernel/microcode.c +2 -2
-  printk(KERN_ERR "microcode: CPU%d updated from revision "
+  printk(KERN_ERR "microcode: CPU%d update from revision "
    "0x%x to 0x%x failed\n", cpu_num, uci->rev, val[1]);
   return;
  }
- pr_debug("microcode: CPU%d updated from revision "
+ printk(KERN_INFO "microcode: CPU%d updated from revision "
         "0x%x to 0x%x, date = %08x \n",
         cpu_num, uci->rev, val[1], uci->mc->hdr.date);
  uci->rev = val[1];

Your mailer client (*cough*) converted tabs to spaces, so the patch does not apply cleanly now.
You'll need to find a way to send patches that does not mangle whitespace.

---
~Randy

#2 lore raw
Quoted 8 lines · Randy Dunlap
Quoted 6 lines · On Wed, 26 Mar 2008 21:22:25 +0100 Ben Castricum wrote:

Show a bit more info when updating microcode. It used to be there but no with DEBUG unset makes it very silent.

This is my first patch, please let me know if I did anything wrong.

A line with "---" after Signed-off-by: is prefered.

A diffstat is also common.

To quote Documentation/SubmittingPatches :
"The canonical patch message body contains the following:

- A "from" line specifying the patch author.

- An empty line.

- The body of the explanation, which will be copied to the permanent changelog to describe this patch.

- The "Signed-off-by:" lines, described above, which will also go in the changelog.

- A marker line containing simply "---".

- Any additional comments not suitable for the changelog.

- The actual patch (diff output).
"

Quoted 17 lines
Quoted 17 lines
arch/x86/kernel/microcode.c +2 -2
index f2702d0..ca1fd52 100644
@@ -336,11 +336,11 @@ static void apply_microcode(int cpu)
 
  spin_unlock_irqrestore(&microcode_update_lock, flags);
  if (val[1] != uci->mc->hdr.rev) {
-  printk(KERN_ERR "microcode: CPU%d updated from revision "
+  printk(KERN_ERR "microcode: CPU%d update from revision "
    "0x%x to 0x%x failed\n", cpu_num, uci->rev, val[1]);
   return;
  }
- pr_debug("microcode: CPU%d updated from revision "
+ printk(KERN_INFO "microcode: CPU%d updated from revision "
         "0x%x to 0x%x, date = %08x \n",
Quoted 9 lines

arch/x86/kernel/microcode.c static void apply_microcode(int cpu) · line 346

Quoted 2 lines
arch/x86/kernel/microcode.c +0 -0
         cpu_num, uci->rev, val[1], uci->mc->hdr.date);
  uci->rev = val[1];

Your mailer client (*cough*) converted tabs to spaces,
so the patch does not apply cleanly now.
You'll need to find a way to send patches that does not mangle whitespace.

Also, since this is a rather trivial patch (even hinted at in the subject) you should probably have added [email protected] to Cc: - if you don't, the chances that I will notice it and pick it up in the trivial tree are pretty slim.

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
#3 lore raw
In reply to Ben Castricum
Quoted 4 lines · Ben Castricum

Show a bit more info when updating microcode. It used to be there but no with DEBUG unset makes it very silent.

This is my first patch, please let me know if I did anything wrong.

your patch looks good to me, but there's some whitespace damage: all your tabs in that patch got converted to spaces. Check out Documentation/email-clients.txt and please resend it so that i can apply it to x86.git.

Ingo