Skip to contentSkip to conversation

Another potential bug in /arch/mips/kernel/sysirix.c

OPERA Zhenmin Li 1 participant 1 message May 20, 2004

lore
Share & tools
lore

Zhenmin Li

author
#0 lore raw

We ran our bug detection tool upon Linux 2.6.6, and found some potential errors.
We would sincerely appreciate your help if anyone can confirm whether they are bugs or not.

Linux 2.6.6, /arch/mips/kernel/sysirix.c, Line 1642

1634 asmlinkage int irix_statvfs64(char *fname, struct irix_statvfs64 *buf) 1635 {

1636         struct nameidata nd;
1637         struct kstatfs kbuf;
1638         int error, i;

1639
1640 printk("[%s:%d] Wheee.. irix_statvfs(%s,%p)\n",
1641 current->comm, current->pid, fname, buf);
!1642 error = verify_area(VERIFY_WRITE, buf, sizeof(struct
irix_statvfs));
1643 if(error)
1644 goto out;

May be changed to:
1634 asmlinkage int irix_statvfs64(char *fname, struct irix_statvfs64 *buf) 1635 {

1636         struct nameidata nd;
1637         struct kstatfs kbuf;
1638         int error, i;

1639
1640 printk("[%s:%d] Wheee.. irix_statvfs(%s,%p)\n",
1641 current->comm, current->pid, fname, buf);
!1642 error = verify_area(VERIFY_WRITE, buf, sizeof(struct
irix_statvfs64));
1643 if(error)
1644 goto out;

Thanks a lot,
OPERA Research Group
University of Illinois at Urbana-Champaign