Skip to contentSkip to conversation

gpio: lynxpoint: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 3 participants 3 messages May 6, 2013 – May 30, 2013 GPIO

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 2/7 gpio: lynxpoint: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/gpio/gpio-lynxpoint.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/gpio/gpio-lynxpoint.c +0 -1
index 86c17de..761c470 100644
@@ -447,7 +447,6 @@ static int lp_gpio_remove(struct platform_device *pdev)
 	err = gpiochip_remove(&lg->chip);
 	if (err)
 		dev_warn(&pdev->dev, "failed to remove gpio_chip.\n");
-	platform_set_drvdata(pdev, NULL);
 	return 0;
 }
 
Signature · 1 line
1.7.2.5
Acked-by on v1 2/7
#1 lore raw
Quoted 15 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
  drivers/gpio/gpio-lynxpoint.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
drivers/gpio/gpio-lynxpoint.c +0 -0
index 86c17de..761c470 100644

drivers/gpio/gpio-lynxpoint.c static int lp_gpio_remove(struct platform_device *pdev) · line 452

Quoted 7 lines
drivers/gpio/gpio-lynxpoint.c +0 -1
@@ -447,7 +447,6 @@ static int lp_gpio_remove(struct platform_device *pdev)
  	err = gpiochip_remove(&lg->chip);
  	if (err)
  		dev_warn(&pdev->dev, "failed to remove gpio_chip.\n");
-	platform_set_drvdata(pdev, NULL);
  	return 0;
  }
 
#2 lore raw
In reply to Jingoo Han
Quoted 6 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Patch applied with Mathias' ACK.

Yours,
Linus Walleij