rtc: rtc-coh901331: remove unnecessary platform_set_drvdata()
PATCH 11/42 rtc: rtc-coh901331: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/rtc/rtc-coh901331.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
drivers/rtc/rtc-coh901331.c +1 -4
@@ -154,10 +154,8 @@ static int __exit coh901331_remove(struct platform_device *pdev) {struct coh901331_port *rtap =dev_get_drvdata (&pdev->dev); -if (rtap) { +if (rtap)clk_unprepare (rtap->clk); -platform_set_drvdata (pdev,NULL ); - }return 0 ; }
@@ -220,7 +218,6 @@ static int __init coh901331_probe(struct platform_device *pdev)return 0 ; out_no_rtc: -platform_set_drvdata (pdev,NULL );clk_unprepare (rtap->clk);return ret; }
Signature · 1 line
1.7.2.5
Quoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Acked-by Linus Walleij <[email protected]>
Yours,
Linus Walleij