Skip to contentSkip to conversation

watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static

PATCH In review Jingoo Han 4 participants 4 messages Feb 11, 2014 – Feb 24, 2014 Watchdog device drivers

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static

Make 'ts72xx_wdt_pdev' static, because it is used only in this file. It also fixes the following sparse warning.

warning: symbol 'ts72xx_wdt_pdev' was not declared. Should it be static?

---
 drivers/watchdog/ts72xx_wdt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/ts72xx_wdt.c +1 -1
index 6959fa0..afa9d6e 100644
@@ -61,7 +61,7 @@ struct ts72xx_wdt {
 	struct platform_device *pdev;
 };
 
-struct platform_device *ts72xx_wdt_pdev;
+static struct platform_device *ts72xx_wdt_pdev;
 
 /*
  * TS-72xx Watchdog supports following timeouts (value written
Signature · 1 line
1.7.10.4
#3 lore raw
In reply to Jingoo Han

Hi Jingoo,

Quoted 27 lines

Make 'ts72xx_wdt_pdev' static, because it is used only in this file. It also fixes the following sparse warning.

warning: symbol 'ts72xx_wdt_pdev' was not declared. Should it be static?

---
 drivers/watchdog/ts72xx_wdt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/ts72xx_wdt.c +1 -1
index 6959fa0..afa9d6e 100644
@@ -61,7 +61,7 @@ struct ts72xx_wdt {
 	struct platform_device *pdev;
 };
 
-struct platform_device *ts72xx_wdt_pdev;
+static struct platform_device *ts72xx_wdt_pdev;
 
 /*
  * TS-72xx Watchdog supports following timeouts (value written
Signature · 1 line
1.7.10.4

This patch has been added to linux-watchdog-next.

Kind regards,
Wim.