pinctrl: mxs: remove unnecessary platform_set_drvdata()
Subsystems (2)
PATCH 2/4 pinctrl: mxs: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
--- drivers/pinctrl/pinctrl-mxs.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/pinctrl/pinctrl-mxs.c +0 -2
@@ -515,7 +515,6 @@ int mxs_pinctrl_probe(struct platform_device *pdev,return 0 ; err: -platform_set_drvdata (pdev,NULL );iounmap (d->base);return ret; }
@@ -525,7 +524,6 @@ int mxs_pinctrl_remove(struct platform_device *pdev) {struct mxs_pinctrl_data *d =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL );pinctrl_unregister (d->pctl);iounmap (d->base);
Signature · 1 line
1.7.2.5
Quoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Quoted 28 lines
--- drivers/pinctrl/pinctrl-mxs.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)drivers/pinctrl/pinctrl-mxs.c +0
-2@@ -515,7 +515,6 @@ int mxs_pinctrl_probe(struct platform_device *pdev,return 0 ; err: -platform_set_drvdata (pdev,NULL );iounmap (d->base);return ret; }@@ -525,7 +524,6 @@ int mxs_pinctrl_remove(struct platform_device *pdev) {struct mxs_pinctrl_data *d =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL );pinctrl_unregister (d->pctl);iounmap (d->base);Signature · 1 line
1.7.2.5
Quoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Patch applied with Shawn's ACK.
Thanks!
Linus Walleij