Skip to contentSkip to conversation

rapidio: fix a NULL pointer dereference when create_workqueue fails

PATCH New Kangjie Lu 1 participant 1 message Mar 19, 2019 1 message not in the archive Rapidio

lore
Share & tools
lore

Kangjie Lu

author
#1 lore raw

PATCH 1/1 rapidio: fix a NULL pointer dereference when create_workqueue fails

In reply to a message not in the archive

In case create_workqueue fails, the fix releases resources and returns -ENOMEM to avoid NULL pointer dereference.

---
 drivers/rapidio/rio_cm.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/rapidio/rio_cm.c +8 -0
index cf45829585cb..b29fc258eeba 100644
@@ -2147,6 +2147,14 @@ static int riocm_add_mport(struct device *dev,
 	mutex_init(&cm->rx_lock);
 	riocm_rx_fill(cm, RIOCM_RX_RING_SIZE);
 	cm->rx_wq = create_workqueue(DRV_NAME "/rxq");
+	if (!cm->rx_wq) {
+		riocm_error("failed to allocate IBMBOX_%d on %s",
+			    cmbox, mport->name);
+		rio_release_outb_mbox(mport, cmbox);
+		kfree(cm);
+		return -ENOMEM;
+	}
+
 	INIT_WORK(&cm->rx_work, rio_ibmsg_handler);
 
 	cm->tx_slot = 0;
Signature · 1 line
2.17.1