Skip to contentSkip to conversation

pcmcia: bfin_cf: remove unnecessary platform_set_drvdata()

PATCH New Jingoo Han 1 participant 3 messages Aug 22, 2013

Subsystems (2)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/3 pcmcia: bfin_cf: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/pcmcia/bfin_cf_pcmcia.c |    2 --
 1 file changed, 2 deletions(-)
drivers/pcmcia/bfin_cf_pcmcia.c +0 -2
index ed3b522..624d127 100644
@@ -281,7 +281,6 @@ fail2:
 fail0:
 	gpio_free(cf->cd_pfx);
 	kfree(cf);
-	platform_set_drvdata(pdev, NULL);
 
 	return status;
 }
@@ -296,7 +295,6 @@ static int bfin_cf_remove(struct platform_device *pdev)
 	del_timer_sync(&cf->timer);
 	iounmap((void __iomem *)cf->socket.io_offset);
 	release_mem_region(cf->phys_cf_io, SZ_8K);
-	platform_set_drvdata(pdev, NULL);
 	kfree(cf);
 	return 0;
 }
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 2/3 pcmcia: pxa2xx: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/pcmcia/pxa2xx_base.c |    2 --
 1 file changed, 2 deletions(-)
drivers/pcmcia/pxa2xx_base.c +0 -2
index cfec9dd..480c61a 100644
@@ -343,8 +343,6 @@ static int pxa2xx_drv_pcmcia_remove(struct platform_device *dev)
 	struct skt_dev_info *sinfo = platform_get_drvdata(dev);
 	int i;
 
-	platform_set_drvdata(dev, NULL);
-
 	for (i = 0; i < sinfo->nskt; i++)
 		soc_pcmcia_remove_one(&sinfo->skt[i]);
 
Signature · 1 line
1.7.10.4
author
#2 lore raw

PATCH 3/3 pcmcia: sa1100: remove unnecessary platform_set_drvdata()

In reply to Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/pcmcia/sa1100_generic.c |    2 --
 1 file changed, 2 deletions(-)
drivers/pcmcia/sa1100_generic.c +0 -2
index ff8a027..fed68e6 100644
@@ -88,8 +88,6 @@ static int sa11x0_drv_pcmcia_remove(struct platform_device *dev)
 	struct skt_dev_info *sinfo = platform_get_drvdata(dev);
 	int i;
 
-	platform_set_drvdata(dev, NULL);
-
 	for (i = 0; i < sinfo->nskt; i++)
 		soc_pcmcia_remove_one(&sinfo->skt[i]);
 
Signature · 1 line
1.7.10.4