crypto: s5p-sss: remove unnecessary platform_set_drvdata()
Subsystems (2)
PATCH 2/2 crypto: s5p-sss: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/crypto/s5p-sss.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/crypto/s5p-sss.c +0 -2
@@ -647,7 +647,6 @@ static int s5p_aes_probe(struct platform_device *pdev)clk_disable (pdata->clk); s5p_dev =NULL ; -platform_set_drvdata (pdev,NULL );return err; }
@@ -668,7 +667,6 @@ static int s5p_aes_remove(struct platform_device *pdev)clk_disable (pdata->clk); s5p_dev =NULL ; -platform_set_drvdata (pdev,NULL );return 0 ; }
Signature · 1 line
1.7.2.5
Quoted 23 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han<[email protected]>--- drivers/crypto/s5p-sss.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)drivers/crypto/s5p-sss.c +0
-1@@ -647,7 +647,6 @@ static int s5p_aes_probe(struct platform_device *pdev)clk_disable (pdata->clk); s5p_dev =NULL ; -platform_set_drvdata (pdev,NULL );return err; }
drivers/crypto/s5p-sss.c static int s5p_aes_remove(struct platform_device *pdev) · line 672
Quoted 7 lines
drivers/crypto/s5p-sss.c +0
-1@@ -668,7 +667,6 @@ static int s5p_aes_remove(struct platform_device *pdev)clk_disable (pdata->clk); s5p_dev =NULL ; -platform_set_drvdata (pdev,NULL );return 0 ; }
--
With best wishes,
Vladimir