PCI: keystone: Remove unnecessary OOM message
PATCH 1/1 PCI: keystone: Remove unnecessary OOM message
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. This patch fixes the following checkpatch warning.
WARNING: Possible unnecessary 'out of memory' message
--- drivers/pci/host/pci-keystone.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/pci/host/pci-keystone.c +2 -3
@@ -353,10 +353,9 @@ static int __init ks_pcie_probe(struct platform_device *pdev) ks_pcie =devm_kzalloc (&pdev->dev,sizeof (*ks_pcie),GFP_KERNEL ); -if (!ks_pcie) { -dev_err (dev,"no memory for keystone pcie\n" ); +if (!ks_pcie)return -ENOMEM ; - } + pp = &ks_pcie->pp;/* initialize SerDes Phy if present */
Signature · 1 line
1.7.9.5
Quoted 7 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. This patch fixes the following checkpatch warning.
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by Jingoo Han <[email protected]>
Applied to pci/host-keystone for v3.19, thanks!
Murali, let me know if you object. I'm trying to clear the easy stuff out of my queue.
Quoted 25 lines
--- drivers/pci/host/pci-keystone.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/pci/host/pci-keystone.c +2
-3@@ -353,10 +353,9 @@ static int __init ks_pcie_probe(struct platform_device *pdev) ks_pcie =devm_kzalloc (&pdev->dev,sizeof (*ks_pcie),GFP_KERNEL ); -if (!ks_pcie) { -dev_err (dev,"no memory for keystone pcie\n" ); +if (!ks_pcie)return -ENOMEM ; - } + pp = &ks_pcie->pp;/* initialize SerDes Phy if present */ Signature · 1 line
1.7.9.5
Quoted 5 lines · Bjorn Helgaas
Quoted 4 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. This patch fixes the following checkpatch warning.
Quoted 7 lines
Quoted 3 lines
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by Jingoo Han<[email protected]>Applied to pci/host-keystone for v3.19, thanks!
Murali, let me know if you object. I'm trying to clear the easy stuff out of my queue.
I think this checkpatch warning is due to recent update to checkpatch.pl script. Looks good to apply. Thanks
Murali
Quoted 25 lines
Quoted 25 lines
--- drivers/pci/host/pci-keystone.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/pci/host/pci-keystone.c +2
-3@@ -353,10 +353,9 @@ static int __init ks_pcie_probe(struct platform_device *pdev) ks_pcie =devm_kzalloc (&pdev->dev,sizeof (*ks_pcie),GFP_KERNEL ); -if (!ks_pcie) { -dev_err (dev,"no memory for keystone pcie\n" ); +if (!ks_pcie)return -ENOMEM ; - } + pp =&ks_pcie->pp;/* initialize SerDes Phy if present */ Signature · 1 line
1.7.9.5
Signature · 2 lines
Murali Karicheri Linux Kernel, Texas Instruments