Skip to contentSkip to conversation

s390: replace strict_strto*() with kstrto*()

PATCH Jingoo Han 1 participant 1 message Jul 22, 2013 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jingoo Han

author
#1 lore raw
Quoted 6 lines · Steffen Maier

Hi, it would have been nice to also CC all affected driver maintainers. I only saw this by accident and noticed that it might collide with my patch queue. Even more so since much of your patch touches code which usually goes through different upstream contributors than the core s390 architecture code.

I will be CC'ing affected driver maintainers.

[.....]

Quoted 19 lines
Quoted 19 lines

drivers/s390/net/qeth_l3_sys.c static ssize_t qeth_l3_dev_sniffer_store(struct device *dev, · line 213

Quoted 13 lines
drivers/s390/net/qeth_l3_sys.c +2 -3
@@ -208,11 +208,10 @@ static ssize_t qeth_l3_dev_sniffer_store(struct device *dev,
  		goto out;
  	}
 
-	rc = strict_strtoul(buf, 16, &i);
-	if (rc) {
-		rc = -EINVAL;
+	rc = kstrtoul(buf, 16, &i);
+	if (rc)
  		goto out;

This hunk e.g. changes the behaviour of a user space interface. Before your patch -ERANGE was mapped to -EINVAL. Now it is not true anymore. This may or may not be a problem, however I'd like to keep the behaviour as is in order to not risk any user space breakage.

Quoted 5 lines
Quoted 2 lines

So if you could resend a new version which just mechanically replaces strict_strtoul() witch kstrtoul() that would be great.

For zfcp we have exactly such a patch from Martin in my zfcp upstream queue which I would send to James in the near future.

I see.

I will NOT modify 'zfcp'.
I will send v2 patch which excludes 'zfcp'.

Best regards,
Jingoo Han