Patch to add the avnet5282 board to u-boot-1.1.4
Hi,
Here you have a patch to add the avnet5282 board to the last u-boot release (1.1.4).
Regards,
Daniel Alomar i Claramonte
Research & Development Electronic Dept.
SERRA SOLDADURA, S.A.
WEB Site: http://www.serrasold.com
Knowledge Site: http://serratron.serrasold.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: uboot1.1.4-avnet5282.patch.tar.bz2
Type: application/octet-stream
Size: 15525 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20060315/410e81b1/attachment.obj
Quoted 2 lines · In message <[email protected]> you wrote:
Here you have a patch to add the avnet5282 board to the last u-boot release
Can you please re-read the patch submission guidelines in the README, and stick to the rules?
You don't include a CHANGELOG entry.
You violate the coding style (trailing white space, indentation,
You include unnecessary code bloat like here:
+#if 1
+ debug ("\n## Get flash bank 1 size @ 0x%08x\n",FLASH_BASE0_PRELIM);
+#endif Please clean this up!
You mess with Copyright notes, like here:
- * (C) Copyright 2000-2004
+ * (C) Copyright 2000
Never do this!!!
You mess with perfectly good indentation, like here:
- cbd_t rxbd[PKTBUFSRX]; /* Rx BD */ - cbd_t txbd[TX_BUF_CNT]; /* Tx BD */ + cbd_t rxbd[PKTBUFSRX]; /* Rx BD */ + cbd_t txbd[TX_BUF_CNT]; /* Tx BD */
You add completely bogus files, like include/asm-m68k/8xx_immap.h - oir definitely makes no sense to have MPC860 specific code in a m68k directory.
Sorry, but this needs A LOT of cleanup. I have to reject it.
Best regards,
Wolfgang Denk
Signature · 4 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Research is what I'm doing when I don't know what I'm doing.
-- Wernher von Braun