Skip to contentSkip to conversation

w1: mxc_w1: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages Aug 22, 2013 – Aug 23, 2013

Subsystems (2)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 w1: mxc_w1: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/w1/masters/mxc_w1.c |    2 --
 1 file changed, 2 deletions(-)
drivers/w1/masters/mxc_w1.c +0 -2
index 47e12cf..15c7251 100644
@@ -152,8 +152,6 @@ static int mxc_w1_remove(struct platform_device *pdev)
 
 	clk_disable_unprepare(mdev->clk);
 
-	platform_set_drvdata(pdev, NULL);
-
 	return 0;
 }
 
Signature · 1 line
1.7.10.4
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

Quoted 21 lines
---
 drivers/w1/masters/mxc_w1.c |    2 --
 1 file changed, 2 deletions(-)
drivers/w1/masters/mxc_w1.c +0 -2
index 47e12cf..15c7251 100644
@@ -152,8 +152,6 @@ static int mxc_w1_remove(struct platform_device *pdev)
 
 	clk_disable_unprepare(mdev->clk);
 
-	platform_set_drvdata(pdev, NULL);
-
 	return 0;
 }
 
Signature · 1 line
1.7.10.4