Skip to contentSkip to conversation

Pre-loader for the avnet5282 board

U-Boot-Users Daniel Alomar 2 participants 2 messages Mar 15, 2006

lore
Share & tools
lore
#0 lore raw

Hi,

This patch add a pre-loader for the avnet5282 board.

Regards,

Daniel Alomar i Claramonte
Research & Development Electronic Dept.
SERRA SOLDADURA, S.A.
WEB Site: http://www.serrasold.com
Knowledge Site: http://serratron.serrasold.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bdm-uboot1.1.4-avnet5282.patch.tar.bz2
Type: application/octet-stream
Size: 17024 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20060315/9f6d4534/attachment.obj

#1 lore raw
Quoted 2 lines · In message <[email protected]> you wrote:

This patch add a pre-loader for the avnet5282 board.

Many filkes of this code do not cointain any Copyright statements, and none of them has any indication about which license applies. Before we can add any code it must be clear that it comes with a GPL compatible license.

Also, this code duplicates a lot of existing functionality, like serial drivers and all this. Also some header files look like duplicates of existing ones. This is not acceptable. Please re-use the existing code.

Your code also violates the Coding Style requirements in several aspects. You have to clean up your code.

Make sure that all files are actually text files, i. e. all lines and with a newline character.

Finally, scripts like your "gdbinit.load", "gdbinit.reset" etc. have no place in this code. Pleas remove these.

Sorry, I have to reject this patch.

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A consultant is a person who borrows your watch, tells you what  time
it is, pockets the watch, and sends you a bill for it.