Skip to contentSkip to conversation

rtc: rtc-spear: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 3, 2013 – May 4, 2013 Real time clock (RTC)

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 34/42 rtc: rtc-spear: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/rtc/rtc-spear.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/rtc/rtc-spear.c +0 -1
index 574359c..c492cf0 100644
@@ -417,7 +417,6 @@ static int spear_rtc_probe(struct platform_device *pdev)
 	return 0;
 
 err_disable_clock:
-	platform_set_drvdata(pdev, NULL);
 	clk_disable_unprepare(config->clk);
 
 	return status;
Signature · 1 line
1.7.2.5
Acked-by on v1 34/42
#1 lore raw
Quoted 9 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/rtc/rtc-spear.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Thanks.