Skip to contentSkip to conversation

f2fs: add unlikely macro for compiler optimization

PATCH In review Chao Yu 2 participants 3 messages Nov 28, 2013 – Dec 2, 2013

Subsystems (2)
lore
Share & tools
lore

Chao Yu

author
#0 lore raw

PATCH 2/5 f2fs: add unlikely macro for compiler optimization

---
 fs/f2fs/node.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/node.c +1 -1
index 0fe9a97..954155b 100644
@@ -1160,7 +1160,7 @@ int wait_on_node_pages_writeback(struct f2fs_sb_info *sbi, nid_t ino)
 			struct page *page = pvec.pages[i];
 
 			/* until radix tree lookup accepts end_index */
-			if (page->index > end)
+			if (unlikely(page->index > end))
 				continue;
 
 			if (ino && ino_of_node(page) == ino) {
Signature · 9 lines
1.7.9.5


------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
#1 lore raw

Hi,

Could you make a patch to add *unlikely* as many as possible across the whole source files at once?
It is wasteful to add it with a bunch of patches at multiple times.

And please write descriptions for all the patches even if nothing is special.
In this case, why should we set *unlikely* for checking this condition?

Thanks,

2013-11-28 (목), 15:42 +0800, Chao Yu:

Quoted 18 lines
---
 fs/f2fs/node.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/node.c +1 -1
index 0fe9a97..954155b 100644
@@ -1160,7 +1160,7 @@ int wait_on_node_pages_writeback(struct f2fs_sb_info *sbi, nid_t ino)
 			struct page *page = pvec.pages[i];
 
 			/* until radix tree lookup accepts end_index */
-			if (page->index > end)
+			if (unlikely(page->index > end))
 				continue;
 
 			if (ino && ino_of_node(page) == ino) {
Signature · 7 lines
Jaegeuk Kim
Samsung

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author
#2 lore raw

Hi Kim,

Quoted 7 lines

-----Original Message-----
From: Jaegeuk Kim [mailto:[email protected]]
Sent: Friday, November 29, 2013 6:14 PM
To: Chao Yu
Cc: [email protected]; [email protected]; [email protected]; 谭姝
Subject: Re: [f2fs-dev] [PATCH 2/5] f2fs: add unlikely macro for compiler optimization

Quoted 5 lines

Hi,

Could you make a patch to add *unlikely* as many as possible across the whole source files at once?
It is wasteful to add it with a bunch of patches at multiple times.

Alright, I will work on this.

Quoted 4 lines

And please write descriptions for all the patches even if nothing is special.
In this case, why should we set *unlikely* for checking this condition?

Got it.

Regards,
Yu

Quoted 21 lines

Thanks,

2013-11-28 (목), 15:42 +0800, Chao Yu:

Quoted 17 lines
---
 fs/f2fs/node.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/node.c +1 -1
index 0fe9a97..954155b 100644
@@ -1160,7 +1160,7 @@ int wait_on_node_pages_writeback(struct f2fs_sb_info *sbi, nid_t ino)
 			struct page *page = pvec.pages[i];
 
 			/* until radix tree lookup accepts end_index */
-			if (page->index > end)
+			if (unlikely(page->index > end))
 				continue;
 
Quoted 5 lines

fs/f2fs/node.c int wait_on_node_pages_writeback(struct f2fs_sb_info *sbi, nid_t ino) · line 1166

Quoted 1 line
fs/f2fs/node.c +0 -0
 			if (ino && ino_of_node(page) == ino) {

--
Jaegeuk Kim
Samsung

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel