Skip to contentSkip to conversation

rtc: rtc-vt8500: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 3, 2013

Subsystems (2)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 38/42 rtc: rtc-vt8500: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/rtc/rtc-vt8500.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/rtc/rtc-vt8500.c +0 -2
index d89efee..c2d6331 100644
@@ -282,8 +282,6 @@ static int vt8500_rtc_remove(struct platform_device *pdev)
 	/* Disable alarm matching */
 	writel(0, vt8500_rtc->regbase + VT8500_RTC_IS);
 
-	platform_set_drvdata(pdev, NULL);
-
 	return 0;
 }
 
Signature · 1 line
1.7.2.5
Acked-by on v1 38/42
#1 lore raw
Quoted 15 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
  drivers/rtc/rtc-vt8500.c |    2 --
  1 files changed, 0 insertions(+), 2 deletions(-)
drivers/rtc/rtc-vt8500.c +0 -0
index d89efee..c2d6331 100644

drivers/rtc/rtc-vt8500.c static int vt8500_rtc_remove(struct platform_device *pdev) · line 287

Quoted 8 lines
drivers/rtc/rtc-vt8500.c +0 -2
@@ -282,8 +282,6 @@ static int vt8500_rtc_remove(struct platform_device *pdev)
  	/* Disable alarm matching */
  	writel(0, vt8500_rtc->regbase + VT8500_RTC_IS);
 
-	platform_set_drvdata(pdev, NULL);
-
  	return 0;
  }