Skip to contentSkip to conversation

88pm860x_battery: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 6, 2013 – Jun 7, 2013

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/8 88pm860x_battery: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/power/88pm860x_battery.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/power/88pm860x_battery.c +0 -1
index d338c1c..dfcda3a 100644
@@ -992,7 +992,6 @@ static int pm860x_battery_remove(struct platform_device *pdev)
 	free_irq(info->irq_batt, info);
 	free_irq(info->irq_cc, info);
 	power_supply_unregister(&info->battery);
-	platform_set_drvdata(pdev, NULL);
 	return 0;
 }
 
Signature · 1 line
1.7.2.5
#1 lore raw
Quoted 6 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

1-8 applied, thanks a lot!

Anton

Quoted 18 lines
---
 drivers/power/88pm860x_battery.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/power/88pm860x_battery.c +0 -1
index d338c1c..dfcda3a 100644
@@ -992,7 +992,6 @@ static int pm860x_battery_remove(struct platform_device *pdev)
 	free_irq(info->irq_batt, info);
 	free_irq(info->irq_cc, info);
 	power_supply_unregister(&info->battery);
-	platform_set_drvdata(pdev, NULL);
 	return 0;
 }
 
Signature · 1 line
1.7.2.5