pinctrl: plgpio: add CONFIG_PM_SLEEP to suspend/resume functions
Subsystems (2)
PATCH 1/1 pinctrl: plgpio: add CONFIG_PM_SLEEP to suspend/resume functions
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following build warning when CONFIG_PM_SLEEP is not selected. This is because sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when the CONFIG_PM_SLEEP is enabled.
drivers/pinctrl/spear/pinctrl-plgpio.c:645:12: warning: 'plgpio_suspend' defined but not used [-Wunused-function] drivers/pinctrl/spear/pinctrl-plgpio.c:684:12: warning: 'plgpio_resume' defined but not used [-Wunused-function]
--- drivers/pinctrl/spear/pinctrl-plgpio.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/pinctrl/spear/pinctrl-plgpio.c +3 -3
@@ -75,7 +75,7 @@ struct plgpio {int (*o2p)(int offset);/* offset_to_pin */ u32 p2o_regs;struct plgpio_regs regs; -#ifdef CONFIG_PM +#ifdef CONFIG_PM_SLEEP struct plgpio_regs *csave_regs;#endif };
@@ -554,7 +554,7 @@ static int plgpio_probe(struct platform_device *pdev)if (IS_ERR (plgpio->clk))dev_warn (&pdev->dev,"clk_get() failed, work without it\n" ); -#ifdef CONFIG_PM +#ifdef CONFIG_PM_SLEEP plgpio->csave_regs = devm_kzalloc(&pdev->dev, sizeof(*plgpio->csave_regs) * DIV_ROUND_UP(plgpio->chip.ngpio, MAX_GPIO_PER_REG),
@@ -641,7 +641,7 @@ unprepare_clk:return ret; } -#ifdef CONFIG_PM +#ifdef CONFIG_PM_SLEEP static int plgpio_suspend (struct device *dev) {struct plgpio *plgpio =dev_get_drvdata (dev);
Signature · 1 line
1.7.2.5
Linus Walleij
AppliedQuoted 9 lines · Jingoo Han
Add
CONFIG_PM_SLEEPto suspend/resume functions to fix the following build warning whenCONFIG_PM_SLEEPis not selected. This is because sleep PM callbacks defined bySIMPLE_DEV_PM_OPSare only used when theCONFIG_PM_SLEEPis enabled.
drivers/pinctrl/spear/pinctrl-plgpio.c:645:12: warning: 'plgpio_suspend' defined but not used [-Wunused-function]drivers/pinctrl/spear/pinctrl-plgpio.c:684:12: warning: 'plgpio_resume' defined but not used [-Wunused-function]Signed-off-by Jingoo Han <[email protected]>
Thanks, applied for fixes.
Yours,
Linus Walleij