Skip to contentSkip to conversation

bq27x00_battery: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 1 participant 1 message May 6, 2013

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 4/8 bq27x00_battery: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/power/bq27x00_battery.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/power/bq27x00_battery.c +0 -2
index 26037ca..b309713 100644
@@ -966,7 +966,6 @@ static int bq27000_battery_probe(struct platform_device *pdev)
 	return 0;
 
 err_free:
-	platform_set_drvdata(pdev, NULL);
 	kfree(di);
 
 	return ret;
@@ -978,7 +977,6 @@ static int bq27000_battery_remove(struct platform_device *pdev)
 
 	bq27x00_powersupply_unregister(di);
 
-	platform_set_drvdata(pdev, NULL);
 	kfree(di);
 
 	return 0;
Signature · 1 line
1.7.2.5