Skip to contentSkip to conversation

cpufreq: intel_pstate: Add Tigerlake support in no-HWP mode

PATCH Applied Doug Smythies 2 participants 2 messages Sep 6, 2022 – Sep 10, 2022 1 message not in the archive

Subsystems (2)
CPU frequency scaling framework Intel pstate driver
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Doug Smythies

author
#1 lore raw

PATCH 1/1 cpufreq: intel_pstate: Add Tigerlake support in no-HWP mode

Users may disable HWP in firmware, in which case intel_pstate wouldn't load unless the CPU model is explicitly supported.

Add TIGERLAKE to the list of CPUs that can register intel_pstate while not advertising the HWP capability. Without this change, an TIGERLAKE in no-HWP mode could only use the acpi_cpufreq frequency scaling driver.

See also commits:
d8de7a44e11f: cpufreq: intel_pstate: Add Skylake servers support
fbdc21e9b038: cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode 706c5328851d: cpufreq: intel_pstate: Add Cometlake support in no-HWP mode

Reported by: M. Cargi Ari <[email protected]>

Signed-off-by Doug Smythies <[email protected]>
---
 drivers/cpufreq/intel_pstate.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/intel_pstate.c +1 -0
index 57cdb3679885..fc3ebeb0bbe5 100644
@@ -2416,6 +2416,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids[] = {
 	X86_MATCH(SKYLAKE_X,		core_funcs),
 	X86_MATCH(COMETLAKE,		core_funcs),
 	X86_MATCH(ICELAKE_X,		core_funcs),
+	X86_MATCH(TIGERLAKE,		core_funcs),
 	{}
 };
 MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);

--
2.25.1

maintainer Applied
#2 lore raw
Quoted 24 lines · Doug Smythies

Users may disable HWP in firmware, in which case intel_pstate wouldn't load unless the CPU model is explicitly supported.

Add TIGERLAKE to the list of CPUs that can register intel_pstate while not advertising the HWP capability. Without this change, an TIGERLAKE in no-HWP mode could only use the acpi_cpufreq frequency scaling driver.

See also commits:
d8de7a44e11f: cpufreq: intel_pstate: Add Skylake servers support
fbdc21e9b038: cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode 706c5328851d: cpufreq: intel_pstate: Add Cometlake support in no-HWP mode

Reported by: M. Cargi Ari <[email protected]>

Signed-off-by Doug Smythies <[email protected]>
---
 drivers/cpufreq/intel_pstate.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/intel_pstate.c +0 -0
index 57cdb3679885..fc3ebeb0bbe5 100644

drivers/cpufreq/intel_pstate.c static const struct x86_cpu_id intel_pstate_cpu_ids[] = {

Quoted 8 lines
drivers/cpufreq/intel_pstate.c +1 -1
@@ -2416,6 +2416,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids[] = {
        X86_MATCH(SKYLAKE_X,            core_funcs),
        X86_MATCH(COMETLAKE,            core_funcs),
        X86_MATCH(ICELAKE_X,            core_funcs),
+       X86_MATCH(TIGERLAKE,            core_funcs),
        {}
 };
 MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
--

Applied as 6.1 material, thanks!