Skip to contentSkip to conversation

cifs: remove unneeded check of null checking in if condition

PATCH Applied Namjae Jeon 2 participants 2 messages Aug 20, 2014 – Aug 21, 2014

Subsystems (2)
SMB client (CIFS) Kernel SMB3 server (ksmbd)
lore
Share & tools
lore

Namjae Jeon

author
#0 lore raw

PATCH 7/7 cifs: remove unneeded check of null checking in if condition

Signed-off-by Namjae Jeon <[email protected]>
Signed-off-by Ashish Sangwan <[email protected]>
---
 fs/cifs/smb2pdu.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
fs/cifs/smb2pdu.c +1 -2
index ab366e5..844c651 100644
@@ -1404,8 +1404,7 @@ SMB2_close(const unsigned int xid, struct cifs_tcon *tcon,
 	rsp = (struct smb2_close_rsp *)iov[0].iov_base;
 
 	if (rc != 0) {
-		if (tcon)
-			cifs_stats_fail_inc(tcon, SMB2_CLOSE_HE);
+		cifs_stats_fail_inc(tcon, SMB2_CLOSE_HE);
 		goto close_exit;
 	}
Signature · 1 line
1.7.7
Applied
#1 lore raw

merged into cifs-2.6.git for-next

Quoted 23 lines · Namjae Jeon
Signed-off-by Namjae Jeon <[email protected]>
Signed-off-by Ashish Sangwan <[email protected]>
---
 fs/cifs/smb2pdu.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
fs/cifs/smb2pdu.c +1 -3
index ab366e5..844c651 100644
@@ -1404,8 +1404,7 @@ SMB2_close(const unsigned int xid, struct cifs_tcon *tcon,
        rsp = (struct smb2_close_rsp *)iov[0].iov_base;
 
        if (rc != 0) {
-               if (tcon)
-                       cifs_stats_fail_inc(tcon, SMB2_CLOSE_HE);
+               cifs_stats_fail_inc(tcon, SMB2_CLOSE_HE);
                goto close_exit;
        }
 
--

1.7.7

Signature · 3 lines
Thanks,

Steve