Skip to contentSkip to conversation

hwrng: bcm63xx - remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 1 participant 1 message May 6, 2013 Hardware random number generator core

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 2/4 hwrng: bcm63xx - remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/char/hw_random/bcm63xx-rng.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/char/hw_random/bcm63xx-rng.c +0 -2
index f343b7d..36581ea 100644
@@ -137,7 +137,6 @@ static int bcm63xx_rng_probe(struct platform_device *pdev)
 out_clk_disable:
 	clk_disable(clk);
 out_free_rng:
-	platform_set_drvdata(pdev, NULL);
 	kfree(rng);
 out_free_priv:
 	kfree(priv);
@@ -154,7 +153,6 @@ static int bcm63xx_rng_remove(struct platform_device *pdev)
 	clk_disable(priv->clk);
 	kfree(priv);
 	kfree(rng);
-	platform_set_drvdata(pdev, NULL);
 
 	return 0;
 }
Signature · 1 line
1.7.2.5