spi: s3c64xx: remove unnecessary platform_set_drvdata()

PATCH Superseded Jingoo Han 1 participant 1 message May 3, 2013

Subsystems (3)

SPI Arm Samsung Exynos Samsung SPI drivers

lore

Share & tools

lore

Jingoo Han

author

2013-05-03 06:53 UTC #0 lore raw

PATCH 15/15 spi: s3c64xx: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>

---
 drivers/spi/spi-s3c64xx.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

drivers/spi/spi-s3c64xx.c +0 -2

index 5000586..5f3759d 100644
@@ -1399,7 +1399,6 @@ err3:
 err2:
 	clk_disable_unprepare(sdd->clk);
 err0:
-	platform_set_drvdata(pdev, NULL);
 	spi_master_put(master);
 
 	return ret;

@@ -1420,7 +1419,6 @@ static int s3c64xx_spi_remove(struct platform_device *pdev)
 
 	clk_disable_unprepare(sdd->clk);
 
-	platform_set_drvdata(pdev, NULL);
 	spi_master_put(master);
 
 	return 0;

Signature · 10 lines

1.7.2.5



------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2