mtd: nand: atmel_nand: remove unnecessary platform_set_drvdata()

PATCH Superseded Jingoo Han 2 participants 2 messages May 7, 2013 – May 8, 2013

Subsystems (3)

Memory technology devices (MTD) Arm/Microchip (AT91) SoC support NAND flash

lore

Share & tools

lore

Jingoo Han

author

2013-05-07 06:33 UTC #0 lore raw

PATCH 11/26 mtd: nand: atmel_nand: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>

---
 drivers/mtd/nand/atmel_nand.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

drivers/mtd/nand/atmel_nand.c +0 -1

index 2d23d29..36c52f5 100644
@@ -1665,7 +1665,6 @@ err_hw_ecc:
 err_scan_ident:
 err_no_card:
 	atmel_nand_disable(host);
-	platform_set_drvdata(pdev, NULL);
 	if (host->dma_chan)
 		dma_release_channel(host->dma_chan);
 err_ecc_ioremap:

Signature · 1 line

1.7.2.5

Josh Wu

Acked-by on v1 11/26

2013-05-08 10:38 UTC #1 lore raw

Quoted 6 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>

Acked-by Josh Wu <[email protected]>

Best Regards,
Josh Wu

Quoted 16 lines

---
  drivers/mtd/nand/atmel_nand.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

drivers/mtd/nand/atmel_nand.c +0 -1

index 2d23d29..36c52f5 100644
@@ -1665,7 +1665,6 @@ err_hw_ecc:
  err_scan_ident:
  err_no_card:
  	atmel_nand_disable(host);
-	platform_set_drvdata(pdev, NULL);
  	if (host->dma_chan)
  		dma_release_channel(host->dma_chan);
  err_ecc_ioremap: