mtd: nand: gpmi-nand: remove unnecessary platform_set_drvdata()
Subsystems (2)
PATCH 15/26 mtd: nand: gpmi-nand: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mtd/nand/gpmi-nand/gpmi-nand.c +0 -2
@@ -1633,7 +1633,6 @@ static int gpmi_nand_probe(struct platform_device *pdev) exit_nfc_init:release_resources (this); exit_acquire_resources: -platform_set_drvdata (pdev,NULL );dev_err (this->dev,"driver registration failed: %d\n" , ret);kfree (this);
@@ -1646,7 +1645,6 @@ static int gpmi_nand_remove(struct platform_device *pdev)gpmi_nfc_exit (this);release_resources (this); -platform_set_drvdata (pdev,NULL );kfree (this);return 0 ; }
Signature · 1 line
1.7.2.5
Quoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Acked-by Shawn Guo <[email protected]>
Quoted 28 lines
--- drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)drivers/mtd/nand/gpmi-nand/gpmi-nand.c +0
-2@@ -1633,7 +1633,6 @@ static int gpmi_nand_probe(struct platform_device *pdev) exit_nfc_init:release_resources (this); exit_acquire_resources: -platform_set_drvdata (pdev,NULL );dev_err (this->dev,"driver registration failed: %d\n" , ret);kfree (this);@@ -1646,7 +1645,6 @@ static int gpmi_nand_remove(struct platform_device *pdev)gpmi_nfc_exit (this);release_resources (this); -platform_set_drvdata (pdev,NULL );kfree (this);return 0 ; }Signature · 1 line
1.7.2.5