Skip to contentSkip to conversation

mmc: mxs-mmc: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 6, 2013

Subsystems (2)
Arm i.MX and Layerscape MMC, SD and SDIO
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 10/22 mmc: mxs-mmc: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mmc/host/mxs-mmc.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mmc/host/mxs-mmc.c +0 -2
index 4278a17..d38f0da 100644
@@ -708,8 +708,6 @@ static int mxs_mmc_remove(struct platform_device *pdev)
 
 	mmc_remove_host(mmc);
 
-	platform_set_drvdata(pdev, NULL);
-
 	if (ssp->dmach)
 		dma_release_channel(ssp->dmach);
Signature · 1 line
1.7.2.5
Acked-by on v1 10/22
#1 lore raw
Quoted 6 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>
Acked-by Shawn Guo <[email protected]>
Quoted 21 lines
---
 drivers/mmc/host/mxs-mmc.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mmc/host/mxs-mmc.c +0 -2
index 4278a17..d38f0da 100644
@@ -708,8 +708,6 @@ static int mxs_mmc_remove(struct platform_device *pdev)
 
 	mmc_remove_host(mmc);
 
-	platform_set_drvdata(pdev, NULL);
-
 	if (ssp->dmach)
 		dma_release_channel(ssp->dmach);
Signature · 1 line
1.7.2.5