Skip to contentSkip to conversation

mfd: max8998: use devm_*() functions

PATCH In review Jingoo Han 1 participant 1 message Aug 20, 2013 Multifunction devices (MFD)

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 2/6 mfd: max8998: use devm_*() functions

Use devm_*() functions to make cleanup paths simpler.

---
 drivers/mfd/max8998.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/mfd/max8998.c +2 -3
index 45bffb8..fe6332d 100644
@@ -188,7 +188,8 @@ static int max8998_i2c_probe(struct i2c_client *i2c,
 	struct max8998_dev *max8998;
 	int ret = 0;
 
-	max8998 = kzalloc(sizeof(struct max8998_dev), GFP_KERNEL);
+	max8998 = devm_kzalloc(&i2c->dev, sizeof(struct max8998_dev),
+				GFP_KERNEL);
 	if (max8998 == NULL)
 		return -ENOMEM;
 
@@ -246,7 +247,6 @@ err:
 	mfd_remove_devices(max8998->dev);
 	max8998_irq_exit(max8998);
 	i2c_unregister_device(max8998->rtc);
-	kfree(max8998);
 	return ret;
 }
 
@@ -257,7 +257,6 @@ static int max8998_i2c_remove(struct i2c_client *i2c)
 	mfd_remove_devices(max8998->dev);
 	max8998_irq_exit(max8998);
 	i2c_unregister_device(max8998->rtc);
-	kfree(max8998);
 
 	return 0;
 }
Signature · 1 line
1.7.10.4