Skip to contentSkip to conversation

mmc: sdhci-s3c: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 6, 2013 – May 7, 2013

Subsystems (3)
MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver Secure digital host controller interface (SDHCI) Samsung driver
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 18/22 mmc: sdhci-s3c: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mmc/host/sdhci-s3c.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/mmc/host/sdhci-s3c.c +0 -1
index c6f6246..926aaf6 100644
@@ -745,7 +745,6 @@ static int sdhci_s3c_remove(struct platform_device *pdev)
 	clk_disable_unprepare(sc->clk_io);
 
 	sdhci_free_host(host);
-	platform_set_drvdata(pdev, NULL);
 
 	return 0;
 }
Signature · 1 line
1.7.2.5
maintainer Acked-by on v1 18/22
#1 lore raw
Acked-by Jaehoon Chung <[email protected]>
Quoted 23 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mmc/host/sdhci-s3c.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/mmc/host/sdhci-s3c.c +0 -1
index c6f6246..926aaf6 100644
@@ -745,7 +745,6 @@ static int sdhci_s3c_remove(struct platform_device *pdev)
 	clk_disable_unprepare(sc->clk_io);
 
 	sdhci_free_host(host);
-	platform_set_drvdata(pdev, NULL);
 
 	return 0;
 }