Skip to contentSkip to conversation

mmc: wmt-sdmmc: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 6, 2013

Subsystems (2)
MMC, SD and SDIO Arm/VT8500 Arm architecture
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 22/22 mmc: wmt-sdmmc: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mmc/host/wmt-sdmmc.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mmc/host/wmt-sdmmc.c +0 -2
index 442f576..34231d5 100644
@@ -927,8 +927,6 @@ static int wmt_mci_remove(struct platform_device *pdev)
 
 	mmc_free_host(mmc);
 
-	platform_set_drvdata(pdev, NULL);
-
 	dev_info(&pdev->dev, "WMT MCI device removed\n");
 
 	return 0;
Signature · 1 line
1.7.2.5
Acked-by on v1 22/22
#1 lore raw
Quoted 15 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>
---
  drivers/mmc/host/wmt-sdmmc.c |    2 --
  1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mmc/host/wmt-sdmmc.c +0 -0
index 442f576..34231d5 100644

drivers/mmc/host/wmt-sdmmc.c static int wmt_mci_remove(struct platform_device *pdev) · line 932

Quoted 8 lines
drivers/mmc/host/wmt-sdmmc.c +0 -2
@@ -927,8 +927,6 @@ static int wmt_mci_remove(struct platform_device *pdev)
 
  	mmc_free_host(mmc);
 
-	platform_set_drvdata(pdev, NULL);
-
  	dev_info(&pdev->dev, "WMT MCI device removed\n");
 
  	return 0;
Acked-by Tony Prisk <[email protected]>