Skip to contentSkip to conversation

MAKEALL script

U-Boot-Users Ulf Samuelsson 2 participants 2 messages Aug 24, 2006

lore
Share & tools
lore
#0 lore raw

The README file says that the MAKEALL script should be run before submitting any patch. Looking closer at this, reveals that the MAKEALL script will only test the PowerPC builds. Not anything else (unless an argument to MAKEALL is provided).

Does this mean that a patch that is only test built on PowerPC is considered acceptable?

Please do not send mails or "reply" to ulfs at dof.se, since it will be routed to my GSM phone.
My email address is ulf at atmel.com

Best Regards
Ulf Samuelsson ulf at atmel.com
Atmel Nordic AB

Mail:  Box 2033, 174 02 Sundbyberg, Sweden
Visit:  Kavalleriv?gen 24, 174 58 Sundbyberg, Sweden

Phone +46 (8) 441 54 22 Fax +46 (8) 441 54 29
GSM +46 (706) 22 44 57

Technical support when I am not available:
AT89 C51 Applications Group: mailto:micro.hotline at nto.atmel.com AT90 AVR Applications Group: mailto:avr at atmel.com AT91 ARM Applications Group: mailto:at91support at atmel.com FPSLIC Application Group: mailto:fpslic at atmel.com Best AVR link: www.avrfreaks.net

#1 lore raw
Quoted 1 line · In message <[email protected]> you wrote:

The README file says that the MAKEALL script should be run before submitting any patch.

Right.

Quoted 2 lines

Looking closer at this, reveals that the MAKEALL script will only test the PowerPC builds. Not anything else (unless an argument to MAKEALL is provided).

It will do what you tell it. It will test a single board, a list of boards, a complete architecture, or a list of architectures, or any combination of these.

Quoted 1 line

Does this mean that a patch that is only test built on PowerPC is considered acceptable?

No. If your patch adds or changes an ARM board and modifies global ARM specific files you are requested to build at least for the whole ARM architecture; if you modify global files you are requested to test all architectures.

I am aware that this is a theoretical request, as probably nobody has allthe required toolchains installed to test *all* systems.

But please test-build as many as possbible.

Best regards,

Wolfgang Denk

Signature · 7 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
				 EARTH
			     smog  |   bricks
			 AIR  --  mud  --  FIRE
			soda water |   tequila
				 WATER