Skip to contentSkip to conversation

scsi: scsi_error: Add helper scsi_eh_sdev_stu to do START_UNIT

RFC PATCH JiangJianJun 2 participants 2 messages Jun 25, 2025 – Jun 26, 2025 SCSI

lore
Share & tools
lore
#0 lore raw
Quoted 21 lines

From: Wenchao Hao <[email protected]>

Add helper function scsi_eh_sdev_stu() to perform START_UNIT and check if to finish some error commands.

Quoted 16 lines

This is preparation for a genernal LUN/target based error handle strategy and did not change original logic.

---
 drivers/scsi/scsi_error.c | 50 +++++++++++++++++++++++----------------
 1 file changed, 29 insertions(+), 21 deletions(-)
drivers/scsi/scsi_error.c +0 -0
index cc3a5adb9daa..3b55642fb585 100644
@@ -1567,6 +1567,31 @@ static int scsi_eh_try_stu(struct scsi_cmnd *scmd)
 	return 1;
 }
 
Quoted 13 lines

drivers/scsi/scsi_error.c static int scsi_eh_try_stu(struct scsi_cmnd *scmd) · line 1579

Quoted 10 lines
drivers/scsi/scsi_error.c +10 -0
+static int scsi_eh_sdev_stu(struct scsi_cmnd *scmd,
+			      struct list_head *work_q,
+			      struct list_head *done_q)
+{
+	struct scsi_device *sdev = scmd->device;
+	struct scsi_cmnd *next;
+
+	SCSI_LOG_ERROR_RECOVERY(3, sdev_printk(KERN_INFO, sdev,
+				"%s: Sending START_UNIT\n", current->comm));
+

As in the scsi_eh_stu, SCSI_SENSE_VALID and scsi_check_sense is required before calling scsi_eh_try_stu.

But the SCSI_SENSE_VALID and scsi_check_sense has been called before calling scsi_eh_try_stu, see in loop devices in scsi_eh_stu, do you means re-call at here?

#1 lore raw
Quoted 36 lines · JiangJianJun
Quoted 13 lines

From: Wenchao Hao <[email protected]>

Add helper function scsi_eh_sdev_stu() to perform START_UNIT and check if to finish some error commands.

Quoted 8 lines

This is preparation for a genernal LUN/target based error handle strategy and did not change original logic.

---
 drivers/scsi/scsi_error.c | 50 +++++++++++++++++++++++----------------
 1 file changed, 29 insertions(+), 21 deletions(-)
Quoted 5 lines

drivers/scsi/scsi_error.c static int scsi_eh_try_stu(struct scsi_cmnd

Quoted 5 lines
drivers/scsi/scsi_error.c +0 -0
index cc3a5adb9daa..3b55642fb585 100644
@@ -1567,6 +1567,31 @@ static int scsi_eh_try_stu(struct scsi_cmnd

*scmd)

Quoted 16 lines

drivers/scsi/scsi_error.c static int scsi_eh_try_stu(struct scsi_cmnd · line 1579

Quoted 13 lines
drivers/scsi/scsi_error.c +10 -0
 	return 1;
 }
 
+static int scsi_eh_sdev_stu(struct scsi_cmnd *scmd,
+			      struct list_head *work_q,
+			      struct list_head *done_q)
+{
+	struct scsi_device *sdev = scmd->device;
+	struct scsi_cmnd *next;
+
+	SCSI_LOG_ERROR_RECOVERY(3, sdev_printk(KERN_INFO, sdev,
+				"%s: Sending START_UNIT\n", current->comm));
+

As in the scsi_eh_stu, SCSI_SENSE_VALID and scsi_check_sense is required before calling scsi_eh_try_stu.

Quoted 3 lines

But the SCSI_SENSE_VALID and scsi_check_sense has been called before calling scsi_eh_try_stu, see in loop devices in scsi_eh_stu, do you means re-call at here?

No, I meant that SCSI_SENSE_VALID and scsi_check_sense are required in scsi_eh_sdev_stu, or perhaps we could move them into scsi_eh_sdev_stu.