syscalls/chmod02: Fix wrong address of buf for write()
--- testcases/kernel/syscalls/chmod/chmod02.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/testcases/kernel/syscalls/chmod/chmod02.c
index 242cbd3..904c5e8 100644
testcases/kernel/syscalls/chmod/chmod02.c +2 -2
@@ -187,9 +187,9 @@ void setup()if ((fd =open (fname,O_RDWR |O_CREAT ,0700 )) ==-1 ) {tst_brkm (TBROK |TERRNO , cleanup,"open(%s, O_RDWR|O_CREAT,0700) failed" , fname); - }else if (write (fd, &buf,strlen (buf)) ==-1 ) { + }else if (write (fd, buf,strlen (buf)) ==-1 ) {tst_brkm (TBROK |TERRNO , cleanup, -"write(%s, &buf, strlen(buf)) failed" , fname); +"write(%s, buf, strlen(buf)) failed" , fname); }else if (close (fd) ==-1 ) { tst_brkm(TBROK | TERRNO, cleanup, "close(%s) failed",
fname);
}
Signature · 1 line
1.7.9.5
Quoted 28 lines
-----Original Message-----
From: Jungsoo Son [mailto:[email protected]]
Sent: Wednesday, June 05, 2013 11:09 AM
To: '[email protected]'
Subject: [PATCH] syscalls/chmod02: Fix wrong address of buf aswrite()argumentSigned-off-by jungsoo.son <[email protected]>--- testcases/kernel/syscalls/chmod/chmod02.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)testcases/kernel/syscalls/chmod/chmod02.c +1
-2@@ -187,7 +187,7 @@ void setup()if ((fd =open (fname,O_RDWR |O_CREAT ,0700 )) ==-1 ) {tst_brkm (TBROK |TERRNO , cleanup,"open(%s, O_RDWR|O_CREAT,0700) failed" , fname); - }else if (write (fd, &buf,strlen (buf)) ==-1 ) { + }else if (write (fd, buf,strlen (buf)) ==-1 ) {tst_brkm (TBROK |TERRNO , cleanup,"write(%s, &buf, strlen(buf)) failed" , fname); }else if (close (fd) ==-1 ) { --
Quoted 1 line
1.7.9.5
------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. A cloud service to automate IT design, transition and operations
2. Dashboards that offer high-level views of enterprise services
3. A single system of record for all IT processes
http://p.sf.net/sfu/servicenow-d2d-j
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Hi!
Quoted 12 lines
Signed-off-by jungsoo.son <[email protected]>--- testcases/kernel/syscalls/chmod/chmod02.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)testcases/kernel/syscalls/chmod/chmod02.c +0
-0@@ -187,9 +187,9 @@ void setup()if ((fd =open (fname,O_RDWR |O_CREAT ,0700 )) ==-1 ) {
testcases/kernel/syscalls/chmod/chmod02.c void setup() · line 195
Quoted 10 lines
testcases/kernel/syscalls/chmod/chmod02.c +2
-2tst_brkm (TBROK |TERRNO , cleanup,"open(%s, O_RDWR|O_CREAT,0700) failed" , fname); - }else if (write (fd, &buf,strlen (buf)) ==-1 ) { + }else if (write (fd, buf,strlen (buf)) ==-1 ) {tst_brkm (TBROK |TERRNO , cleanup, -"write(%s, &buf, strlen(buf)) failed" , fname); +"write(%s, buf, strlen(buf)) failed" , fname); }else if (close (fd) ==-1 ) {tst_brkm (TBROK |TERRNO , cleanup,"close(%s) failed" , fname);
I've replaced the the code that creates the file with single SAFE_FILE_PRINTF(). Thanks for the report.
Signature · 13 lines
Cyril Hrubis [email protected] ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. A cloud service to automate IT design, transition and operations 2. Dashboards that offer high-level views of enterprise services 3. A single system of record for all IT processes http://p.sf.net/sfu/servicenow-d2d-j _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list