Skip to contentSkip to conversation

hwrng: exynos - add CONFIG_PM_RUNTIME to suspend/resume functions

PATCH In review Jingoo Han 3 participants 4 messages Mar 21, 2013 – Mar 22, 2013

Subsystems (2)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

Add CONFIG_PM_RUNTIME to suspend/resume functions to fix the build error. It is because UNIVERSAL_DEV_PM_OPS macro is related to both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.

drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a function) drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a function)

---
 drivers/char/hw_random/exynos-rng.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/hw_random/exynos-rng.c +1 -1
index b7e48a2..402ccfb 100644
@@ -144,7 +144,7 @@ static int exynos_rng_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM_SLEEP
+#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
 static int exynos_rng_runtime_suspend(struct device *dev)
 {
 	struct platform_device *pdev = to_platform_device(dev);
Signature · 1 line
1.7.2.5
author
#1 lore raw

PATCH 1/1 hwrng: exynos - add CONFIG_PM_RUNTIME to suspend/resume functions

Add CONFIG_PM_RUNTIME to suspend/resume functions to fix the build error. It is because UNIVERSAL_DEV_PM_OPS macro is related to both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.

drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a function) drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a function)

---
 drivers/char/hw_random/exynos-rng.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/hw_random/exynos-rng.c +1 -1
index b7e48a2..402ccfb 100644
@@ -144,7 +144,7 @@ static int exynos_rng_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM_SLEEP
+#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
 static int exynos_rng_runtime_suspend(struct device *dev)
 {
 	struct platform_device *pdev = to_platform_device(dev);
Signature · 1 line
1.7.2.5
Acked-by on v1 1/1
#2 lore raw
Quoted 10 lines · Jingoo Han

Add CONFIG_PM_RUNTIME to suspend/resume functions to fix the build error. It is because UNIVERSAL_DEV_PM_OPS macro is related to both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.

drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a function) drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a function)

#3 lore raw
Quoted 6 lines · David Rientjes
Quoted 4 lines · Jingoo Han

Add CONFIG_PM_RUNTIME to suspend/resume functions to fix the build error. It is because UNIVERSAL_DEV_PM_OPS macro is related to both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.

Quoted 8 lines
Quoted 6 lines

drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a function) drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a function)

Thanks, I've folded this into the original patch and rebased the tree so that it is bisectable.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt