Skip to contentSkip to conversation

non intrusive "install" feature

U-Boot-Users Ulf Samuelsson 2 participants 2 messages Aug 23, 2006

lore
Share & tools
lore
#0 lore raw

Have been thinking about how to accomodate Wolfgangs remarks on install feature and still get what I desire.

This patch creates the framework for an "install" feature.
The toplevel Makefile 'includes' the file "install.mk" which currently is empty.

Since the "install.mk" file is empty, the patch does not do anything at the moment. Anyone can add his/her own install feature by modifying the install.mk file

Any such install feature will not break as a result of modificaitons of the main Makefile so they can easily be applied on top of a new "git".

The Top
Best Regards
Ulf Samuelsson ulf at atmel.com
Atmel Nordic AB

Mail:  Box 2033, 174 02 Sundbyberg, Sweden
Visit:  Kavalleriv?gen 24, 174 58 Sundbyberg, Sweden

Phone +46 (8) 441 54 22 Fax +46 (8) 441 54 29
GSM +46 (706) 22 44 57

Technical support when I am not available:
AT89 C51 Applications Group: mailto:micro.hotline at nto.atmel.com
AT90 AVR Applications Group: mailto:avr at atmel.com
AT91 ARM Applications Group: mailto:at91support at atmel.com
FPSLIC Application Group: mailto:fpslic at atmel.com
Best AVR link: www.avrfreaks.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 9.install-feature.CHANGELOG
Type: application/octet-stream
Size: 411 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20060823/57605164/attachment.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 9.install-feature.patch
Type: application/octet-stream
Size: 1050 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20060823/57605164/attachment-0001.obj

#1 lore raw

Dear Ulf,

Quoted 4 lines · in message <[email protected]> you wrote:

This patch creates the framework for an "install" feature. The toplevel Makefile 'includes' the file "install.mk" which currently is empty.

Previos comments about distributin information apply here, too.

Quoted 4 lines

Since the "install.mk" file is empty, the patch does not do anything at the moment.
Anyone can add his/her own install feature by modifying the install.mk file

What is the difference between editing "Makefile" and "install.mk" (except that typing "install.mk" takes two more characters) ?

What do we win with your patch?

Quoted 3 lines

Any such install feature will not break as a result of modificaitons of the main Makefile
so they can easily be applied on top of a new "git".

You just shifted the problem to a different file. To me this is not better, but actually worse.

Quoted 6 lines

Content-Disposition: attachment;
filename="9.install-feature.CHANGELOG"

Have been thinking about how to accomodate Wolfgangs remarks on install feature and still get what I desire.

Quoted 8 lines

This patch creates the framework for an "install" feature. The toplevel Makefile 'includes' the file "install.mk" which currently is empty.

Since the "install.mk" file is empty, the patch does not do anything at the moment.
Anyone can add his/her own install feature by modifying the install.mk file

Ummm.... Please have a look at the CHANGELOG file for the correct format of CHANGELOG entries. Thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Winners never talk about glorious victories. That's  because  they're
the  ones  who  see  what the battlefield looks like afterwards. It's
only the losers who have glorious victories.
                                      - Terry Pratchett, _Small Gods_