Skip to contentSkip to conversation

Add definition of keypad platform data

PATCH New 양진성 2 participants 3 messages Sep 5, 2009 – Sep 7, 2009

Subsystems (2)
lore
Share & tools
lore

양진성

author
#0 lore raw

PATCH 7/12 Add definition of keypad platform data

This patch includes platform data header of keypad driver and extern definition of function to set platform data.

---
 arch/arm/plat-s3c/include/plat/keypad.h |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-s3c/include/plat/keypad.h
arch/arm/plat-s3c/include/plat/keypad.h new file +14 -0
new file mode 100644
index 0000000..caf2417
@@ -0,0 +1,14 @@
+#ifndef __ASM_PLAT_S3C_KEYPAD_H
+#define __ASM_PLAT_S3C_KEYPAD_H
+
+struct s3c_platform_keypad {
+	int nr_rows;
+	int nr_cols;
+	int max_keys;
+	int max_masks;
+	int delay;
+};
+
+extern void s3c_keypad_set_platdata(struct s3c_platform_keypad *pd);
+
+#endif /* __ASM_PLAT_S3C_KEYPAD_H */
Signature · 1 line
1.6.2.5
#1 lore raw

PATCH 7/12 Add definition of keypad platform data

2009/9/5 ??? <[email protected]>:

Quoted 16 lines

This patch includes platform data header of keypad driver and extern definition of function to set platform data.

---
?arch/arm/plat-s3c/include/plat/keypad.h | ? 14 ++++++++++++++ ?1 files changed, 14 insertions(+), 0 deletions(-) ?create mode 100644 arch/arm/plat-s3c/include/plat/keypad.h

arch/arm/plat-s3c/include/plat/keypad.h new file +0 -0
new file mode 100644
index 0000000..caf2417

arch/arm/plat-s3c/include/plat/keypad.h line 2

Quoted 2 lines
arch/arm/plat-s3c/include/plat/keypad.h new file +2 -0
@@ -0,0 +1,14 @@
+#ifndef __ASM_PLAT_S3C_KEYPAD_H
+#define __ASM_PLAT_S3C_KEYPAD_H

Also you missed the copyright here.

arch/arm/plat-s3c/include/plat/keypad.h line 10

Quoted 8 lines
arch/arm/plat-s3c/include/plat/keypad.h new file +8 -0
+
+struct s3c_platform_keypad {
+ ? ? ? int nr_rows;
+ ? ? ? int nr_cols;
+ ? ? ? int max_keys;
+ ? ? ? int max_masks;
+ ? ? ? int delay;
+};

Don't you need the keymap at here?
And please consider s5pc1xx series. you already aware the s5pc1xx series keypad.
Also add the cfg_gpio at here.

Thank you,
Kyungmin Park

Quoted 13 lines
arch/arm/plat-s3c/include/plat/keypad.h new file +4 -1
+
+extern void s3c_keypad_set_platdata(struct s3c_platform_keypad *pd);
+
+#endif /* __ASM_PLAT_S3C_KEYPAD_H */
--

1.6.2.5

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw

PATCH 7/12 Add definition of keypad platform data

Quoted 33 lines

-----Original Message-----
From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-arm- kernel-bounces at lists.infradead.org] On Behalf Of Kyungmin Park
Sent: Monday, September 07, 2009 9:08 AM
To: ???
Cc: linux-arm-kernel at lists.infradead.org; ???/AP???/E3/????; ben- linux at fluff.org
Subject: Re: [PATCH 07/12] [ARM][S3C6410] Add definition of keypad platform data

2009/9/5 ??? <[email protected]>:

arch/arm/plat-

Quoted 11 lines

This patch includes platform data header of keypad driver and extern definition of function to set platform data.

---
 arch/arm/plat-s3c/include/plat/keypad.h |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-s3c/include/plat/keypad.h
arch/arm/plat- renamed from arch/arm/plat-s3c/include/plat/keypad.h +0 -0

s3c/include/plat/keypad.h

arch/arm/plat-s3c/include/plat/keypad.h line 2

Quoted 7 lines

new file mode 100644
index 0000000..caf2417

arch/arm/plat-s3c/include/plat/keypad.h new file +2 -0
@@ -0,0 +1,14 @@
+#ifndef __ASM_PLAT_S3C_KEYPAD_H
+#define __ASM_PLAT_S3C_KEYPAD_H

Also you missed the copyright here.

Quoted 13 lines

arch/arm/plat-s3c/include/plat/keypad.h line 10

Quoted 8 lines
arch/arm/plat-s3c/include/plat/keypad.h new file +8 -0
+
+struct s3c_platform_keypad {
+       int nr_rows;
+       int nr_cols;
+       int max_keys;
+       int max_masks;
+       int delay;
+};

Don't you need the keymap at here?
And please consider s5pc1xx series. you already aware the s5pc1xx series keypad.
Also add the cfg_gpio at here.

We got some recommendations about gpio function that the cfg_gpio() calls in the driver source code is not good idea. Harald, could you explain the details again about gpio function call?

Quoted 22 lines

Thank you,
Kyungmin Park

Quoted 8 lines
arch/arm/plat-s3c/include/plat/keypad.h new file +4 -1
+
+extern void s3c_keypad_set_platdata(struct s3c_platform_keypad *pd);
+
+#endif /* __ASM_PLAT_S3C_KEYPAD_H */
--

1.6.2.5

Quoted 5 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel