backlight: lm3630: remove ret = -EIO of lm3630_backlight_register()
Subsystems (2)
PATCH 1/1 backlight: lm3630: remove ret = -EIO of lm3630_backlight_register()
There is no need to return -EIO, because backlight_device_register() already returns correct error values.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/video/backlight/lm3630_bl.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/video/backlight/lm3630_bl.c +2 -2
@@ -320,7 +320,7 @@ static int lm3630_backlight_register(struct lm3630_chip_data *pchip,backlight_device_register (name, pchip->dev, pchip, &lm3630_bank_a_ops, &props);if (IS_ERR (pchip->bled1)) -return -EIO ; +return PTR_ERR (pchip->bled1);break ;case BLED_2 : props.brightness = pdata->init_brt_led2;
@@ -329,7 +329,7 @@ static int lm3630_backlight_register(struct lm3630_chip_data *pchip,backlight_device_register (name, pchip->dev, pchip, &lm3630_bank_b_ops, &props);if (IS_ERR (pchip->bled2)) -return -EIO ; +return PTR_ERR (pchip->bled2);break ; }return 0 ;
Signature · 1 line
1.7.2.5
2013년 02월 04일 09:14, Jingoo Han 쓴 글:
Quoted 22 lines
There is no need to return
-EIO, becausebacklight_device_register()already returns correct error values.Signed-off-by Jingoo Han <[email protected]>--- drivers/video/backlight/lm3630_bl.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/video/backlight/lm3630_bl.c +1
-1@@ -320,7 +320,7 @@ static int lm3630_backlight_register(struct lm3630_chip_data *pchip,backlight_device_register (name, pchip->dev, pchip, &lm3630_bank_a_ops, &props);if (IS_ERR (pchip->bled1)) -return -EIO ; +return PTR_ERR (pchip->bled1);break ;case BLED_2 : props.brightness = pdata->init_brt_led2;
drivers/video/backlight/lm3630_bl.c static int lm3630_backlight_register(struct lm3630_chip_data *pchip, · line 335
Quoted 8 lines
drivers/video/backlight/lm3630_bl.c +1
-1@@ -329,7 +329,7 @@ static int lm3630_backlight_register(struct lm3630_chip_data *pchip,backlight_device_register (name, pchip->dev, pchip, &lm3630_bank_b_ops, &props);if (IS_ERR (pchip->bled2)) -return -EIO ; +return PTR_ERR (pchip->bled2);break ; }return 0 ;
Thank you. This patch looks good for us.
Acked-by Daniel Jeong<[email protected]>