f2fs: verify file type early in f2fs_fallocate
PATCH 3/7 f2fs: verify file type early in f2fs_fallocate
This patch changes to verify file type early in f2fs_fallocate for cleanup, meanwhile this also fixes to add missing verification for expand_inode_data.
Signed-off-by Chao Yu <[email protected]>
--- fs/f2fs/file.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-)
fs/f2fs/file.c +4 -12
@@ -775,9 +775,6 @@ static int punch_hole(struct inode *inode, loff_t offset, loff_t len)loff_t off_start, off_end;int ret =0 ; -if (!S_ISREG (inode->i_mode)) -return -EOPNOTSUPP ; -if (f2fs_has_inline_data (inode)) { ret =f2fs_convert_inline_inode (inode);if (ret)
@@ -918,9 +915,6 @@ static int f2fs_collapse_range(struct inode *inode, loff_t offset, loff_t len)loff_t new_size;int ret; -if (!S_ISREG (inode->i_mode)) -return -EINVAL ; -if (offset + len >=i_size_read (inode))return -EINVAL ;
@@ -969,9 +963,6 @@ static int f2fs_zero_range(struct inode *inode, loff_t offset, loff_t len,loff_t off_start, off_end;int ret =0 ; -if (!S_ISREG (inode->i_mode)) -return -EINVAL ; - ret =inode_newsize_ok (inode, (len + offset));if (ret)return ret;
@@ -1078,9 +1069,6 @@ static int f2fs_insert_range(struct inode *inode, loff_t offset, loff_t len)loff_t new_size;int ret; -if (!S_ISREG (inode->i_mode)) -return -EINVAL ; - new_size =i_size_read (inode) + len;if (new_size > inode->i_sb->s_maxbytes)return -EFBIG ;
@@ -1238,6 +1226,10 @@ static long f2fs_fallocate(struct file *file, int mode,struct inode *inode =file_inode (file);long ret =0 ; +/* f2fs only support ->fallocate for regular file */ +if (!S_ISREG (inode->i_mode)) +return -EINVAL ; +if (f2fs_encrypted_inode (inode) && (mode & (FALLOC_FL_COLLAPSE_RANGE |FALLOC_FL_INSERT_RANGE )))return -EOPNOTSUPP ;
Signature · 1 line
2.4.2